Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93418
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BY2PR0201MB1784296F01E558FF22C48C7ABF4B0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB1784296F01E558FF22C48C7ABF4B0@BY2PR0201MB1784.namprd02.prod.outlook.com>
Date: Fri, 20 May 2016 15:54:07 +0200
Message-ID: <CAF+90c_KWrE0PE9p-BWZz9uXaLFUarnbp3h30rN3THz9S7pLjQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Xinchen Hui <xinchen.h@zend.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1140c3ecae78f00533466c64
Subject: Re: "finally" handling refactoring (Bug #72213)
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1140c3ecae78f00533466c64
Content-Type: text/plain; charset=UTF-8

On Fri, May 20, 2016 at 2:07 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> hi,
>
>
> Please review the path
> https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330
>
>
> I hope, it should completely fix https://bugs.php.net/bug.php?id=72213
>
>
> I'm going to commit this on Monday.
>
>
> Thanks. Dmitry.
>
From a quick look:

https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L74
=> should this be orig_try_catch_offset?

https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L303
=> This assumes that either there's a catch block or a finally block to go
to. However, if we're in the catch block of a try/catch (without finally)
that may not be true.

Also, this still leaks one exception :(

<?php

function test() {
    try {
        throw new Exception(1);
    } finally {
        try {
            throw new Exception(2);
        } finally {
            return 42;
        }
    }
}

test();

Nikita

--001a1140c3ecae78f00533466c64--