Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93414 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78655 invoked from network); 20 May 2016 12:47:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 May 2016 12:47:51 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Received: from [82.113.146.227] ([82.113.146.227:56232] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D8/70-08692-5770F375 for ; Fri, 20 May 2016 08:47:50 -0400 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 098B510D46A; Fri, 20 May 2016 13:47:45 +0100 (BST) Date: Fri, 20 May 2016 13:47:45 +0100 (BST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Dmitry Stogov cc: Nikita Popov , Xinchen Hui , internals In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [PHP-DEV] "finally" handling refactoring (Bug #72213) From: derick@php.net (Derick Rethans) On Fri, 20 May 2016, Dmitry Stogov wrote: > Please review the path > https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330 https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L194-L196 https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L356-L358 Why are you switching these around? https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L500-L501 https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72213-diff-L511-L512 You should probably remove them instead of commenting them out. And Nikita, does this fix my issues with trying to walk through the possible paths and branches with Xdebug? > > I hope, it should completely fix https://bugs.php.net/bug.php?id=72213 > > > I'm going to commit this on Monday. To which branches? cheers, Derick