Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93408
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.161 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAF1yvAQozS1qpCbBNdAJu4gT5LbOEUimv2W-nWtkaUTbVZFubA@mail.gmail.com>
References: <CADqTB_jC-EZ5p+c=q0dmRgaYAkyRVbdNFNUQRGhfaS7GaOTR9g@mail.gmail.com>
	<72f547d6-5fcf-3cd2-960d-cb612a429e47@php.net>
	<CANUQDCiEDeCV3RAr0bg+=-PHPDYkk-cP-ih4TnTGUzz7SNakMw@mail.gmail.com>
	<CADqTB_j67-ocNaWm5sRHbC4vJF2t7WBWUqrEXu9-Kk_MSi4CgA@mail.gmail.com>
	<CAF1yvAQozS1qpCbBNdAJu4gT5LbOEUimv2W-nWtkaUTbVZFubA@mail.gmail.com>
Date: Fri, 20 May 2016 09:22:07 +0200
Message-ID: <CANUQDCjnEgJwT5zEb50sWA5=OeF-LRzPDu_1+-E70as2N10oXw@mail.gmail.com>
To: Jesse Schalken <me@jesseschalken.com>
Cc: Rasmus Schultz <rasmus@mindplay.dk>, Sebastian Bergmann <sebastian@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1130cf14cbfb6d053340f22a
Subject: Re: [PHP-DEV] Exception::getLine()
From: me@kelunik.com (Niklas Keller)

--001a1130cf14cbfb6d053340f22a
Content-Type: text/plain; charset=UTF-8

2016-05-20 4:13 GMT+02:00 Jesse Schalken <me@jesseschalken.com>:

>
> On Fri, May 20, 2016 at 4:35 AM, Rasmus Schultz <rasmus@mindplay.dk>
> wrote:
>
>> This is inconsistent with at least JavaScript and C#, where the stack
>> trace is populated at the throw site. (Probably others?)
>>
>
> I'm not sure about C#, but in JavaScript (Node.js):
>
> function get_error() {
>     return new Error('my error');
> }
>
> function do_throw(e) {
>     throw e;
> }
>
> try {
>     do_throw(get_error());
> } catch (e) {
>     console.log(e.stack);
> }
>
>
> results in:
>
> Error: my error
>     at get_error (/home/jesse/src/test.js:2:12)
>     at Object.<anonymous> (/home/jesse/src/test.js:10:14)
>     at Module._compile (module.js:413:34)
>     at Object.Module._extensions..js (module.js:422:10)
>     at Module.load (module.js:357:32)
>     at Function.Module._load (module.js:314:12)
>     at Function.Module.runMain (module.js:447:10)
>     at startup (node.js:146:18)
>     at node.js:404:3
>
>
> The top frame is the construction (get_error) and the site of the throw
> (do_throw) doesn't appear in the stack at all.
>

The comparison with JavaScript isn't a good one, since you can throw
everything in JS. If they didn't provide the stack trace upon throw, you
would not have a stack trace at all if you throw a plain string.

--001a1130cf14cbfb6d053340f22a--