Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93378
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
To: internals@lists.php.net
References: <CADqTB_i5WL+rzCuFHkRmXsPj16WDc4eWmpAoFmyeuYXvuOP_NQ@mail.gmail.com>
 <CAEPJdunJ-67CqJq2hzvmnEmuOFQRGpxv8iycq3CnocXR4r20vw@mail.gmail.com>
 <CADqTB_iUDGHXUR5cYUDuzL4XrqJk-Jf0oce_uj6ZUtEYr7fTYw@mail.gmail.com>
 <CAEPJdunVsJWkOez3ERdpsKjFx8oxPmWVropZ5n9VKTfKdokpXg@mail.gmail.com>
 <CADqTB_jzRPG2CNXniyyo2XA36GGy_s29i5SGPfYe4c8gcpnK6g@mail.gmail.com>
 <61e6a083-91c2-799f-9757-02f56fe184e9@gmail.com>
 <CADqTB_jB-bXU5FjJoEqx-qTCiX6NSoo9YtxxHiX1X40FqmJ9Pg@mail.gmail.com>
 <ec6a9d04-83d0-1b70-4418-281e4b3f5a54@fleshgrinder.com>
 <CADqTB_jNcQ24=KC68vrpvXAEmeTJH9Xk4kB9Yr4Pi+3vRWsJiw@mail.gmail.com>
 <CADqTB_jM4-3JZt_t2yQtroDfS7ZSSLp6FNmHWVa+kqh3znsNBQ@mail.gmail.com>
Message-ID: <b3f54e07-a19c-83d6-6ad5-e8e4ee56e9d9@gmail.com>
Date: Tue, 17 May 2016 16:28:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <CADqTB_jM4-3JZt_t2yQtroDfS7ZSSLp6FNmHWVa+kqh3znsNBQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Simple Annotations
From: rowan.collins@gmail.com (Rowan Collins)

On 17/05/2016 15:22, Rasmus Schultz wrote:
> The other issue is the dependency (context) injection example - no one
> seems to be able to cite an actual use-case, and if that's the case, I
> should probably just remove it from the RFC entirely?
>
> @Larry can you think of a case example in the myriad annotations
> you've seen in Drupal code? :-)
>
> Anyone else using Doctrine Annotations actually seen anyone making use
> of a closure in an annotation?

Possibly nobody's responded to your call for an example because they're 
not sure what it is you're asking for an example of. I don't really 
understand what closures have to do with annotations, or how that 
relates to capturing context.

An example from the other thread of a context-bound annotation would be 
implementing validation like this:

<<ValidateRange($percentage, 0, 100)>>
function foo(int $percentage)


This would appear to be unsupported as such by your proposal, so you 
would instead just have to use strings to represent how it needed to be 
accessed:

<<new ValidateRangeAnnotation('$percentage', 0, 100)>>

and then have extra machinery in the reflection logic to extract the 
parameters and pass them to the object, e.g. 
$annotation->validate($reflected_parameters)


This might be the more sensible approach to such an annotation anyway, 
but without any access to variables, I don't really understand the value 
of evaluating an expression for the annotation, just to get a constant 
value that is cached by the Reflection infrastructure.

If the expression would have to be made up entirely of constants anyway, 
might the same "constant expressions" used in class const definitions be 
a better fit than "any valid PHP expression" - plus a specific exception 
for creating objects out of those constant expressions.

Regards,
-- 
Rowan Collins
[IMSoP]