Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93305
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFp73Xs_9C7crXR0mVbE7SAvkdM345LgxCCd0DMBRKvY0W41JQ@mail.gmail.com>
References: <CAFp73Xs_9C7crXR0mVbE7SAvkdM345LgxCCd0DMBRKvY0W41JQ@mail.gmail.com>
Date: Fri, 13 May 2016 12:36:09 +0700
Message-ID: <CAEZPtU7=W1jo1ccUna0Xusmr=RmY1pwWgKYr07oO35Kb6bCngA@mail.gmail.com>
To: Guilherme Blanco <guilhermeblanco@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c09b6f6e9f1eb0532b2a656
Subject: Re: [PHP-DEV] Assess acceptability of having php-ds into core
From: pierre.php@gmail.com (Pierre Joye)

--94eb2c09b6f6e9f1eb0532b2a656
Content-Type: text/plain; charset=UTF-8

Hi

On May 13, 2016 8:28 AM, "guilhermeblanco@gmail.com" <
guilhermeblanco@gmail.com> wrote:
>
> Hi internals,
>
> PHP 7 leverages a lot the performance internally and many PHP applications
> in the wild. Much of these improvement came by experimentation through
> PHPNG and the usage of efficient data structures internally. This idea of
> performance improvements are crucial to handle more requests, reduce
server
> overload, etc.
>
> However, what lacks in PHP is the exposure of more efficient, use case
> specific data structures, that could allow end users to easily improve
> performance of their applications, instead of using a general,
> multi-purpose data structure that we have as "array".
>
> Based on that (please keep in mind I haven't spoken with library author),
> I'd like assess the receptability of incorporating php-ds library into
core.
>
> Library author wrote a good (and lengthy) article explaining his
motivation
> and performance benchmarks around it. Here are the related links:
>
> Article:
>
https://medium.com/@rtheunissen/efficient-data-structures-for-php-7-9dda7af674cd
> Extension: https://github.com/php-ds/extension
> Polyfill: https://github.com/php-ds/polyfill
> Tests: https://github.com/php-ds/tests
> Benchmark: https://github.com/php-ds/benchmarks

I like this ext. Good work.

However I am not a fan to include as is. Many duplicates with spl. And we
know too well that (standard)pl is a kind of a mess as it gets everything
possible without too much thoughts about consistent APIs or if it makes
sense. Or if one part fits better in the engine directly.

Adding yet another extension to achieve  similar goals, even if it is
better, is not going to help to improve the situation, in contrary.

I would prefer to discuss each structure individually to see if we need it,
where it should be and how it should be done from an api pov.

Cheers
Pierre

--94eb2c09b6f6e9f1eb0532b2a656--