Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93279
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEPJdumSdAQvf6gx57QFROOQY_fwfq9R2-d4M4giZPUqLnu7WQ@mail.gmail.com>
References: <BY2PR0201MB17842998E88EF93DEEA9ABACBF710@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <CAEPJdumSdAQvf6gx57QFROOQY_fwfq9R2-d4M4giZPUqLnu7WQ@mail.gmail.com>
Date: Thu, 12 May 2016 16:53:55 +0200
Message-ID: <CADyq6sLABxW4D0=7kwHe5wd6tbGX3yRFzaSAv2GJe2A8uJXAhg@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Dmitry Stogov <dmitry@zend.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11425326f6ebad0532a6546a
Subject: Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
From: ocramius@gmail.com (Marco Pivetta)

--001a11425326f6ebad0532a6546a
Content-Type: text/plain; charset=UTF-8

On 12 May 2016 at 16:29, Benjamin Eberlei <kontakt@beberlei.de> wrote:

> On Tue, May 10, 2016 at 8:29 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
> > Hi internals,
> >
> >
> > I've started voting on "PHP Attributes" RFC.
> >
> >
> > https://wiki.php.net/rfc/attributes
> >
> >
> > In my opinion, "PHP Attributes" might be a smart tool for PHP extension,
> > but it's not going to be the end of the world, if we decided to live with
> > doc-comments only.
> >
> >
> > Thanks. Dmitry.
> >
>
> I voted -1
>
> Reasons: from a Doctrine Annotations maintainer perspective, either getting
> a list (without keys) of strings back or ast\nodes are not enough or way
> too advanced for our use-case. The middle ground is missing where a
> <php-constant> (Name borrowed from the RFC) can be an arbitrarily deep
> nested array, that means getAttributes() does should not only return
> "string" or ast\node as result for each attribute, to there should be a way
> to get arrays back.
>
> Example:
>
> https://gist.github.com/beberlei/18db9f7d5f6157b817348a58fa2aee25
>
> greetings
> Benjamin
>

Urgh, that is indeed quirky, and makes it unusable.

Is that an implementation or a spec issue? I know PHP 5.6+ allows array
constants, but I am not aware of whether that is in the specification.

Indeed, show-stopper here. I'll have to vote "-1" for now, and wait for a
version that either explicitly contains any constant expression or just
supports arrays as constants.

I'll also need to compile the branch and try it out myself before voting
further: my bad for being hasty.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a11425326f6ebad0532a6546a--