Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93278
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 74.125.82.53 cause and error)
MIME-Version: 1.0
In-Reply-To: <BY2PR0201MB17842998E88EF93DEEA9ABACBF710@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB17842998E88EF93DEEA9ABACBF710@BY2PR0201MB1784.namprd02.prod.outlook.com>
Date: Thu, 12 May 2016 16:29:40 +0200
Message-ID: <CAEPJdumSdAQvf6gx57QFROOQY_fwfq9R2-d4M4giZPUqLnu7WQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b874c241786d90532a5fd40
Subject: Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
From: kontakt@beberlei.de (Benjamin Eberlei)

--047d7b874c241786d90532a5fd40
Content-Type: text/plain; charset=UTF-8

On Tue, May 10, 2016 at 8:29 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi internals,
>
>
> I've started voting on "PHP Attributes" RFC.
>
>
> https://wiki.php.net/rfc/attributes
>
>
> In my opinion, "PHP Attributes" might be a smart tool for PHP extension,
> but it's not going to be the end of the world, if we decided to live with
> doc-comments only.
>
>
> Thanks. Dmitry.
>

I voted -1

Reasons: from a Doctrine Annotations maintainer perspective, either getting
a list (without keys) of strings back or ast\nodes are not enough or way
too advanced for our use-case. The middle ground is missing where a
<php-constant> (Name borrowed from the RFC) can be an arbitrarily deep
nested array, that means getAttributes() does should not only return
"string" or ast\node as result for each attribute, to there should be a way
to get arrays back.

Example:

https://gist.github.com/beberlei/18db9f7d5f6157b817348a58fa2aee25

greetings
Benjamin

--047d7b874c241786d90532a5fd40--