Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93242 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69836 invoked from network); 11 May 2016 15:02:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 May 2016 15:02:53 -0000 Authentication-Results: pb1.pair.com header.from=pthreads@pthreads.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=pthreads@pthreads.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.161.177 cause and error) X-PHP-List-Original-Sender: pthreads@pthreads.org X-Host-Fingerprint: 209.85.161.177 mail-yw0-f177.google.com Received: from [209.85.161.177] ([209.85.161.177:36190] helo=mail-yw0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 94/9E-28272-C9943375 for ; Wed, 11 May 2016 11:02:52 -0400 Received: by mail-yw0-f177.google.com with SMTP id o66so50636530ywc.3 for ; Wed, 11 May 2016 08:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pthreads-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=kDI5RuheompG+Z/ZykPjeYyXE2cJLAU3SQj29jubvT4=; b=ChNFxbs0c6an3Id/ns6SbGq9kUlUwPxxWiOm3acnBnXgvaKLl1Hq1oV/4zdgB9tDVt r659pW+TWRJ0L4pb7CbfKtiYeMNbXBL12LFthBffhzv0yO2L/zppZoRdUpkBi/KlGrml 9ueSTqn2SWsYQzpaoJYx3qDGYHb8qOLCC6Vx4kCGWNBrMzjwKWEWyR+HJKFj2eraxL5u /0/8q5m79ebbcGbs1E1cN9g55W/GHp9ConRNX8y09vAUD+YzKQBTFM2SPF6stCJ6Piol Ajz9gOqvj7SrVSiB7pJE1/NJchHup2NpelIG99v3G+pTJjlM28fDssvFubjDf14nWDZi DJSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=kDI5RuheompG+Z/ZykPjeYyXE2cJLAU3SQj29jubvT4=; b=bwvZIGmQnqGTbAnUIr8GGhz8igb+GGbw79LzI+kBQrGtV3kz2w5HmjF8HSmwLd6yhA sWMu3bDw6yX5Az+nY6d1fa/sPzFB0btqYTJhVNWX0z4nqu6GUwcMMQhjlo266IMb1pWp EzKhC11lPddEkqH0ndp5mZPQT8hUIHoWTdboR88EZZ6X2B9Eoo6mFC20LwEFjBBDTmgE aQD7zV0TXlGgNwBe6qjgCj2qXJAh6ywkyS16WwTvk9wHZhRP7uHkk4fsxjI5/zD5MWIZ 7hxNsw3mXRmTvb/pqoBe9KDYu3e0qisgUtUUgJDBDhAqT6NxnYibSWJkrDq26/YFOvd2 gBjw== X-Gm-Message-State: AOPr4FXZSj7ZM9npIoFGn11PIjgTmST/svrRMDEV+Mc2uVeChO3+ISkGd99LycmwfZBgBlfklpmJ5l+beWkYCA== MIME-Version: 1.0 X-Received: by 10.37.222.198 with SMTP id v189mr1653002ybg.135.1462978969992; Wed, 11 May 2016 08:02:49 -0700 (PDT) Received: by 10.129.109.67 with HTTP; Wed, 11 May 2016 08:02:49 -0700 (PDT) X-Originating-IP: [165.120.173.102] In-Reply-To: References: Date: Wed, 11 May 2016 16:02:49 +0100 Message-ID: To: Dmitry Stogov Cc: Bob Weinand , Nikita Popov , Xinchen Hui , internals Content-Type: multipart/alternative; boundary=94eb2c0872bcd2693e0532925590 Subject: Re: [PHP-DEV] Single Stack for all generators From: pthreads@pthreads.org (Joe Watkins) --94eb2c0872bcd2693e0532925590 Content-Type: text/plain; charset=UTF-8 404 Cheers Joe On Wed, May 11, 2016 at 3:54 PM, Dmitry Stogov wrote: > Hi, > > > Nikita, please review the patch > https://gist.github.com/dstogov/06116f1610f45f8152ine3a9927c6c243ac > > It's the next attempt to use the single stack for all generators. > > Now I don't see any problems or BC breaks. > > > In case "yield" is used as an expression in context of function call. e.g. > var_dump(yield), engine backups and then restores active call frame chain. > > > Bob tested the patch on application that intensively uses generators, and > reported: > > 15% less L2 cache loads > > 20% less cycle stalls due to memory subsystem > > 3% more CPU_CLOCK_UNHALTED due to additional freeze/restore. > > > I'm going to commit this patch tomorrow. > > > Thanks. Dmitry. > --94eb2c0872bcd2693e0532925590--