Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93208
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.110.143 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>
References: <BY2PR0201MB17842998E88EF93DEEA9ABACBF710@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <a29968e2-49af-57a1-425e-eff2ef77c96c@telia.com>
 <b358960d-f2f1-27d7-4a23-2a23eee8647c@zend.com>
 <8d5d1c42-832d-4406-6bb5-dbf3fc02c364@telia.com>
 <CAL=_i_=rGQbJxKUBF4M36U=mzEOX5shA83PnHQ8Vi5N_psk1SA@mail.gmail.com>
 <BY2PR0201MB1784E2F42D1B2A85F0134EE1BF720@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <CAL=_i_nkz=_WrEp__5x9R0h=nkqMBCVruwrsBNS3O3Y7sLqi6w@mail.gmail.com>
 <95ccaf31-11de-8efb-13ba-038d36a6c466@zend.com>
 <CAL=_i_=k=hUDhMC4UXHyv6UUcn4xBuXqjxiWhS_iS+YnPWdwCg@mail.gmail.com>
CC: =?UTF-8?Q?Bj=c3=b6rn_Larsson?= <bjorn.x.larsson@telia.com>, PHP internals
	<internals@lists.php.net>
Message-ID: <001d497d-0117-b337-422b-7192cbed3070@zend.com>
Date: Wed, 11 May 2016 10:11:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <CAL=_i_=k=hUDhMC4UXHyv6UUcn4xBuXqjxiWhS_iS+YnPWdwCg@mail.gmail.com>
Content-Type: multipart/alternative;
	boundary="------------51397BD661B9289436BB5229"
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2016 07:11:37.6682 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1778
Subject: Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
From: dmitry@zend.com (Dmitry Stogov)

--------------51397BD661B9289436BB5229
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit



On 05/11/2016 09:57 AM, Joe Watkins wrote:
> Dmitry,
>
> > but it's possible to get the same power translating string values of 
> attributes into AST in the hooks.
>
> Aware.
>
> Enough of the complexity is already the responsibility of the consumer 
> of the attributes.
>
> It's already possible to get strings (and so AST) from doc comments, 
> we don't need anything new if that's all you want to do.
>
> Essentially, moving something from doc comments to <<here>> makes zero 
> sense to me.

Except the fact, that doc-comment content don't have to conform to any 
rules, and you have to parse it and extract the necessary part of meta 
information every time you need it. It's not a big problem to do this 
using Doctrine library, but how are you going to do this in a compiler hook?

>
> Cheers
> Joe
>
> On Wed, May 11, 2016 at 7:45 AM, Dmitry Stogov <dmitry@zend.com 
> <mailto:dmitry@zend.com>> wrote:
>
>
>
>     On 05/11/2016 09:02 AM, Joe Watkins wrote:
>>     Morning Dmitry,
>>
>>     > On the other hand simple string may be parsed into AST with
>>     just one additional call to ast\compile_string().
>>
>>     You're not really suggesting that I write my tools in user land,
>>     are you ? It's me, Joe :)ce
>
>     At first days of RFC discussion Sara pointed on over-design
>     regarding AST.
>     I saw sense in here comments and updated RFC.
>
>>
>>     I *only* want attributes as they were originally proposed, and I
>>     can't vote to reflect that.
>>
>>     As discussed in private, what I want is attributes, as originally
>>     proposed, and a hookable compiler; Anything else is not good enough.
>
>     Personally, I'm for AST as well, but it's possible to get the same
>     power translating string values of attributes into AST in the hooks.
>
>     Thanks. Dmitry.
>
>
>>
>>     Cheers
>>     Joe
>>
>>
>>
>>     On Wed, May 11, 2016 at 6:26 AM, Dmitry Stogov <dmitry@zend.com
>>     <mailto:dmitry@zend.com>> wrote:
>>
>>         Hi Joe,
>>
>>
>>         The sense in native support for AST is questionable.
>>
>>
>>         On one hand this allows syntax verification.
>>
>>
>>         On the other hand simple string may be parsed into AST with
>>         just one additional call to ast\compile_string().
>>
>>
>>         Thanks. Dmitry.
>>
>>
>>         ------------------------------------------------------------------------
>>         *From:* Joe Watkins <pthreads@pthreads.org
>>         <mailto:pthreads@pthreads.org>>
>>         *Sent:* Wednesday, May 11, 2016 7:46:09 AM
>>         *To:* Björn Larsson
>>         *Cc:* Dmitry Stogov; PHP internals
>>         *Subject:* Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
>>         Morning Dmitry,
>>
>>             I'm not really happy with the voting options here.
>>
>>             I would not vote in favour of a patch that does not
>>         include support for AST, that's a completely different feature.
>>
>>             As it is, I have to vote yes in favour of AST, but it may
>>         be counted as a vote in favour of attributes without AST ...
>>
>>             This doesn't seem right ... I don't want attributes
>>         without AST, and there is no voting option to reflect that.
>>
>>         Cheers
>>         Joe
>>
>>         On Tue, May 10, 2016 at 11:09 PM, Björn Larsson
>>         <bjorn.x.larsson@telia.com
>>         <mailto:bjorn.x.larsson@telia.com>> wrote:
>>
>>             Den 2016-05-11 kl. 00:00, skrev Dmitry Stogov:
>>
>>
>>
>>                 On 05/11/2016 12:29 AM, Björn Larsson wrote:
>>
>>                     Den 2016-05-10 kl. 20:29, skrev Dmitry Stogov:
>>
>>                         Hi internals,
>>
>>
>>                         I've started voting on "PHP Attributes" RFC.
>>
>>
>>                         https://wiki.php.net/rfc/attributes
>>
>>
>>                         In my opinion, "PHP Attributes" might be a
>>                         smart tool for PHP extension, but it's not
>>                         going to be the end of the world, if we
>>                         decided to live with doc-comments only.
>>
>>
>>                         Thanks. Dmitry.
>>
>>                     Thanks for the good work. Regarding naming, I googled
>>                     "PHP attributes" vs "PHP annotations" and looking
>>                     at the
>>                     result, my view is that that Annotation is a
>>                     better naming
>>                     then Attributes. Any hope in changing it?
>>
>>
>>                 The more I listen to arguments of adepts of existing
>>                 PHP annotation systems, the more I think, that "PHP
>>                 attributes" is the right name for this proposal.
>>                 This feature is not just for PHP annotation systems.
>>
>>
>>             Thats a fair point, so Annotation it's not. Still, when I
>>             hear PHP
>>             attributes I associate it with class / function
>>             attributes. Maybe
>>             just a question getting used to the naming. Hm, wonder if PHP
>>             directives could have been an option?
>>
>>             Regards //Björn
>>
>>
>>
>>             -- 
>>             PHP Internals - PHP Runtime Development Mailing List
>>             To unsubscribe, visit:
>>             <http://www.php.net/unsub.php>http://www.php.net/unsub.php
>>
>>
>>
>
>


--------------51397BD661B9289436BB5229--