Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93201
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.161.179 cause and error)
MIME-Version: 1.0
In-Reply-To: <BY2PR0201MB1784E2F42D1B2A85F0134EE1BF720@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB17842998E88EF93DEEA9ABACBF710@BY2PR0201MB1784.namprd02.prod.outlook.com>
	<a29968e2-49af-57a1-425e-eff2ef77c96c@telia.com>
	<b358960d-f2f1-27d7-4a23-2a23eee8647c@zend.com>
	<8d5d1c42-832d-4406-6bb5-dbf3fc02c364@telia.com>
	<CAL=_i_=rGQbJxKUBF4M36U=mzEOX5shA83PnHQ8Vi5N_psk1SA@mail.gmail.com>
	<BY2PR0201MB1784E2F42D1B2A85F0134EE1BF720@BY2PR0201MB1784.namprd02.prod.outlook.com>
Date: Wed, 11 May 2016 07:02:42 +0100
Message-ID: <CAL=_i_nkz=_WrEp__5x9R0h=nkqMBCVruwrsBNS3O3Y7sLqi6w@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c06b32e2babf805328aca87
Subject: Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
From: pthreads@pthreads.org (Joe Watkins)

--94eb2c06b32e2babf805328aca87
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Morning Dmitry,

> On the other hand simple string may be parsed into AST with just one
additional call to ast\compile_string().

You're not really suggesting that I write my tools in user land, are you ?
It's me, Joe :)

I *only* want attributes as they were originally proposed, and I can't vote
to reflect that.

As discussed in private, what I want is attributes, as originally proposed,
and a hookable compiler; Anything else is not good enough.

Cheers
Joe



On Wed, May 11, 2016 at 6:26 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Joe,
>
> The sense in native support for AST is questionable.
>
>
> On one hand this allows syntax verification.
>
>
> On the other hand simple string may be parsed into AST with just one
> additional call to ast\compile_string().
>
>
> Thanks. Dmitry.
>
>
> ------------------------------
> *From:* Joe Watkins <pthreads@pthreads.org>
> *Sent:* Wednesday, May 11, 2016 7:46:09 AM
> *To:* Bj=C3=B6rn Larsson
> *Cc:* Dmitry Stogov; PHP internals
> *Subject:* Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
>
> Morning Dmitry,
>
>     I'm not really happy with the voting options here.
>
>     I would not vote in favour of a patch that does not include support
> for AST, that's a completely different feature.
>
>     As it is, I have to vote yes in favour of AST, but it may be counted
> as a vote in favour of attributes without AST ...
>
>     This doesn't seem right ... I don't want attributes without AST, and
> there is no voting option to reflect that.
>
> Cheers
> Joe
>
> On Tue, May 10, 2016 at 11:09 PM, Bj=C3=B6rn Larsson <bjorn.x.larsson@tel=
ia.com
> > wrote:
>
>> Den 2016-05-11 kl. 00:00, skrev Dmitry Stogov:
>>
>>>
>>>
>>> On 05/11/2016 12:29 AM, Bj=C3=B6rn Larsson wrote:
>>>
>>>> Den 2016-05-10 kl. 20:29, skrev Dmitry Stogov:
>>>>
>>>> Hi internals,
>>>>>
>>>>>
>>>>> I've started voting on "PHP Attributes" RFC.
>>>>>
>>>>>
>>>>> https://wiki.php.net/rfc/attributes
>>>>>
>>>>>
>>>>> In my opinion, "PHP Attributes" might be a smart tool for PHP
>>>>> extension, but it's not going to be the end of the world, if we decid=
ed to
>>>>> live with doc-comments only.
>>>>>
>>>>>
>>>>> Thanks. Dmitry.
>>>>>
>>>>> Thanks for the good work. Regarding naming, I googled
>>>> "PHP attributes" vs "PHP annotations" and looking at the
>>>> result, my view is that that Annotation is a better naming
>>>> then Attributes. Any hope in changing it?
>>>>
>>>
>>> The more I listen to arguments of adepts of existing PHP annotation
>>> systems, the more I think, that "PHP attributes" is the right name for =
this
>>> proposal.
>>> This feature is not just for PHP annotation systems.
>>>
>>
>> Thats a fair point, so Annotation it's not. Still, when I hear PHP
>> attributes I associate it with class / function attributes. Maybe
>> just a question getting used to the naming. Hm, wonder if PHP
>> directives could have been an option?
>>
>> Regards //Bj=C3=B6rn
>>
>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>

--94eb2c06b32e2babf805328aca87--