Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93200
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 207.46.100.112 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>, =?iso-8859-1?Q?Bj=F6rn_Larsson?=
	<bjorn.x.larsson@telia.com>
CC: PHP internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] [VOTE] PHP Attributes
Thread-Index: AQHRqujrArbaZdp9akukn5WuZj/XV5+ysEmAgAA62wD//9BHAIAAbtWAgAAJW7c=
Date: Wed, 11 May 2016 05:26:35 +0000
Message-ID: <BY2PR0201MB1784E2F42D1B2A85F0134EE1BF720@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB17842998E88EF93DEEA9ABACBF710@BY2PR0201MB1784.namprd02.prod.outlook.com>
	<a29968e2-49af-57a1-425e-eff2ef77c96c@telia.com>
	<b358960d-f2f1-27d7-4a23-2a23eee8647c@zend.com>
	<8d5d1c42-832d-4406-6bb5-dbf3fc02c364@telia.com>,<CAL=_i_=rGQbJxKUBF4M36U=mzEOX5shA83PnHQ8Vi5N_psk1SA@mail.gmail.com>
In-Reply-To: <CAL=_i_=rGQbJxKUBF4M36U=mzEOX5shA83PnHQ8Vi5N_psk1SA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR0201MB1784E2F42D1B2A85F0134EE1BF720BY2PR0201MB1784_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2016 05:26:35.7922
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1782
Subject: Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY2PR0201MB1784E2F42D1B2A85F0134EE1BF720BY2PR0201MB1784_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi Joe,


The sense in native support for AST is questionable.


On one hand this allows syntax verification.


On the other hand simple string may be parsed into AST with just one additi=
onal call to ast\compile_string().


Thanks. Dmitry.


________________________________
From: Joe Watkins <pthreads@pthreads.org>
Sent: Wednesday, May 11, 2016 7:46:09 AM
To: Bj=F6rn Larsson
Cc: Dmitry Stogov; PHP internals
Subject: Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes

Morning Dmitry,

    I'm not really happy with the voting options here.

    I would not vote in favour of a patch that does not include support for=
 AST, that's a completely different feature.

    As it is, I have to vote yes in favour of AST, but it may be counted as=
 a vote in favour of attributes without AST ...

    This doesn't seem right ... I don't want attributes without AST, and th=
ere is no voting option to reflect that.

Cheers
Joe

On Tue, May 10, 2016 at 11:09 PM, Bj=F6rn Larsson <bjorn.x.larsson@telia.co=
m<mailto:bjorn.x.larsson@telia.com>> wrote:
Den 2016-05-11 kl. 00:00, skrev Dmitry Stogov:


On 05/11/2016 12:29 AM, Bj=F6rn Larsson wrote:
Den 2016-05-10 kl. 20:29, skrev Dmitry Stogov:

Hi internals,


I've started voting on "PHP Attributes" RFC.


https://wiki.php.net/rfc/attributes


In my opinion, "PHP Attributes" might be a smart tool for PHP extension, bu=
t it's not going to be the end of the world, if we decided to live with doc=
-comments only.


Thanks. Dmitry.

Thanks for the good work. Regarding naming, I googled
"PHP attributes" vs "PHP annotations" and looking at the
result, my view is that that Annotation is a better naming
then Attributes. Any hope in changing it?

The more I listen to arguments of adepts of existing PHP annotation systems=
, the more I think, that "PHP attributes" is the right name for this propos=
al.
This feature is not just for PHP annotation systems.

Thats a fair point, so Annotation it's not. Still, when I hear PHP
attributes I associate it with class / function attributes. Maybe
just a question getting used to the naming. Hm, wonder if PHP
directives could have been an option?

Regards //Bj=F6rn



--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



--_000_BY2PR0201MB1784E2F42D1B2A85F0134EE1BF720BY2PR0201MB1784_--