Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93138
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEPJdunpiPPYOtTnWFk6TFTB=+zSzz=+i=VXGaW9k8x23QjvMw@mail.gmail.com>
References: <alpine.DEB.2.20.1605091428490.20710@whisky.home.derickrethans.nl>
	<2aa755ee-0f6b-c52a-8422-05acfa30a673@php.net>
	<CAEPJdunpiPPYOtTnWFk6TFTB=+zSzz=+i=VXGaW9k8x23QjvMw@mail.gmail.com>
Date: Mon, 9 May 2016 21:36:49 -0700
Message-ID: <CAMbn9ZFevE4CzZC4ZpZgiE8tZFk96mP0jo7wkbGVPf8VAnnV2w@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: =?UTF-8?Q?Fran=C3=A7ois_Laupretre?= <francois@php.net>, 
	Derick Rethans <derick@php.net>, PHP Developers Mailing List <internals@lists.php.net>, Anatol Belski <ab@php.net>
Content-Type: multipart/alternative; boundary=001a113b08503619b805327579d1
Subject: Re: [PHP-DEV] run-tests.php improvement for PHP 7.0+
From: themattficken@gmail.com (Matt Ficken)

--001a113b08503619b805327579d1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

An INI section wouldn't have the extension directory path AND wouldn't have
the name of the SO to load. On Windows, its zend_extension=3Dphp_opcache.DL=
L.
Typically the same opcache, etc... feature/test should work across os
platforms.

OpCache tests can just use a SKIPIF section to be skipped unless the user
has configured OpCache to be loaded. Forcing OpCache to be loaded makes
sure that test gets run during a casual test run (somebody just running
`make test`). That's what a ZEND_EXTENSION section would do. There are
several new section types already.

If you really want to add a ZEND_EXTENSIONS section, that's fine.

It is important though to have SKIPIF code that checks for such zend
extensions being loaded:

That allows for backwards compatibility.

Also, that will avoid a mismatch with PFTT... PFTT has scenarios that can
load/configure extensions for all tests to be run, fe: run all tests with
opcache enabled or run all tests with opcache disabled. SKIPIF code would
allow such PHPTs to be skipped or not for those scenarios, otherwise there
is a mismatch in features between PFTT and run-test.php.


Regards
-M

On Mon, May 9, 2016 at 9:07 PM, Benjamin Eberlei <kontakt@beberlei.de>
wrote:

> On Tue, May 10, 2016 at 2:51 AM, Fran=C3=A7ois Laupretre <francois@php.ne=
t>
> wrote:
>
> > Hi Derick,
> >
> >
> > Le 09/05/2016 =C3=A0 20:36, Derick Rethans a =C3=A9crit :
> >
> >> Hi!
> >>
> >> I've recently been having some looks at issues between xdebug and
> >> opcache, and this meant that I need to write a test case for it.
> >>
> >> Ages ago I added support for the "--EXTENSIONS--" section in .phpt
> >> files, to load extensions that the test 'depends' on. Each item would =
be
> >> added to the php invocation as a "-dextension=3Dname.so". For opcache
> >> however, that needs to be "-dzend_extension=3Dopcache.so".
> >>
> >> The attached patch checks for opcache in the list of extensions and th=
en
> >> uses zend_extension=3D. I'd like to have this in PHP 7.0 and trunk - a=
ny
> >> objections?
> >>
> >> cheers,
> >> Derick
> >>
> >
> > I know there are not so many Zend extensions around, but I would
> > definitely prefer a 'ZEND_EXTENSIONS' section.
> >
>
> Wouldn't this work by just using --INI-- instead?
>
> --INI--
> zend_extension=3Dopcache.so
>
> greetings
> Benjamin
>
>
> >
> > Regards
> >
> > Fran=C3=A7ois
> >
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>

--001a113b08503619b805327579d1--