Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93061
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 207.46.100.109 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>, Derick Rethans <derick@php.net>
CC: PHP Developers Mailing List <internals@lists.php.net>
Thread-Topic: [PHP-DEV] zend_pass_function/zif_pass
Thread-Index: AQHRowOFGkOwnOk2pUebQ+tgupdMN5+iyNwAgAWNM2A=
Date: Wed, 4 May 2016 06:28:29 +0000
Message-ID: <CY1PR0201MB17869D2C997B7E65341097DABF7B0@CY1PR0201MB1786.namprd02.prod.outlook.com>
References: <alpine.DEB.2.20.1604301806470.3295@whisky.home.derickrethans.nl>,<CAF+90c-SMthSnfmb7HNZBXhB+PDD+Bj5mbgg7CTkU9Teb127iA@mail.gmail.com>
In-Reply-To: <CAF+90c-SMthSnfmb7HNZBXhB+PDD+Bj5mbgg7CTkU9Teb127iA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_CY1PR0201MB17869D2C997B7E65341097DABF7B0CY1PR0201MB1786_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2016 06:28:29.0190
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1786
Subject: Re: [PHP-DEV] zend_pass_function/zif_pass
From: dmitry@zend.com (Dmitry Stogov)

--_000_CY1PR0201MB17869D2C997B7E65341097DABF7B0CY1PR0201MB1786_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

I don't see a big problem exporting zif_pass, if this's really necessary.


Thanks. Dmitry.

________________________________
From: Nikita Popov <nikita.ppv@gmail.com>
Sent: Saturday, April 30, 2016 8:40:54 PM
To: Derick Rethans
Cc: Dmitry Stogov; PHP Developers Mailing List
Subject: Re: [PHP-DEV] zend_pass_function/zif_pass

On Sat, Apr 30, 2016 at 7:12 PM, Derick Rethans <derick@php.net<mailto:deri=
ck@php.net>> wrote:
Hi!

I'm trying to make Xdebug up to date with master again, and after fixing
the static changes that Dmitry highlighted, I am still baffled by
something else.

My function traces now have an extra entry for each constructor - even
for classes that have no constructor, such as stdClass.

Code

<?php
$tf =3D xdebug_start_trace(sys_get_temp_dir() . '/'. uniqid('xdt', TRUE));

$a =3D new StdClass;

xdebug_stop_trace();
echo file_get_contents($tf);
?>

In PHP 7.1 (master) this generates:

                           =3D> $tf =3D '/tmp/xdt5724dfa31b3050.51884776.xt=
' /home/derick/dev/php/derickr-xdebug/tests/assignment-trace11.php:2
    0.0017     386376     -> {main}() /home/derick/dev/php/derickr-xdebug/t=
ests/assignment-trace11.php:0
                           =3D> $a =3D class stdClass {  } /home/derick/dev=
/php/derickr-xdebug/tests/assignment-trace11.php:4
    0.0017     386472     -> xdebug_stop_trace() /home/derick/dev/php/deric=
kr-xdebug/tests/assignment-trace11.php:6
    0.0018     386568

Where as in PHP 5.6 and 7.0, it generates:

TRACE START [2016-04-30 17:10:19]
                           =3D> $tf =3D '/tmp/xdt5724e6fb674b31.38510038.xt=
' /home/derick/dev/php/derickr-xdebug/tests/assignment-trace11.php:2
                           =3D> $a =3D class stdClass {  } /home/derick/dev=
/php/derickr-xdebug/tests/assignment-trace11.php:4
    0.0006     274008     -> xdebug_stop_trace() /home/derick/dev/php/deric=
kr-xdebug/tests/assignment-trace11.php:6
    0.0006     274128
TRACE END   [2016-04-30 17:10:19]

The master version has the extra {main}, which comes from an additional
call to zend_execute_internal.

When looking into this, I see that that extra frame is a handle
zend_pass_function / zif_pass. How has this changed recently, and more
importantly, how can I detect this? I can't do "edata.func =3D=3D
zend_pass_function" as neither zend_pass_function or zif_pass are
exported symbols.

Any hints on how to handle this?

cheers,
Derick

Hey Derick!

This change is due to http://www.serverphorums.com/read.php?7,1439618,14396=
18 / https://github.com/php/php-src/commit/8e5b139732893d2a5f6ba3ae0a0b2b5c=
f6dba09f.

I don't see a good way for you to handle this as things stand now. I think =
we should export the zend_pass_function symbol.

Nikita

--_000_CY1PR0201MB17869D2C997B7E65341097DABF7B0CY1PR0201MB1786_--