Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93023
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.180 as permitted sender)
To: Larry Garfield <larry@garfieldtech.com>, internals@lists.php.net
References: <5723F2AE.2020806@garfieldtech.com>
 <f6a2370f-0468-6279-3981-82ed2eec4b90@gmail.com>
 <572529F2.9070606@garfieldtech.com>
 <8e4ed849-f504-fe80-3c5f-e4ea114e99fa@gmail.com>
 <6e3f41ce-4dd5-cd29-a063-fdc9c9c920b8@gmail.com>
 <830b1059-9a9e-b7e1-e338-29d562588e2f@gmail.com>
 <d0bdd623-7374-f081-0227-41613a1266d1@gmail.com>
 <57265D57.1040301@garfieldtech.com>
Message-ID: <5c15ae70-f3dd-6c8a-caaf-d584b7ded8ae@gmail.com>
Date: Sun, 1 May 2016 13:20:00 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0)
 Gecko/20100101 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <57265D57.1040301@garfieldtech.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Attributes/Annotations Case Study: Drupal
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> It would never occur to me to not have it regenerated on each access.
If I want to cache it I will do so myself, thanks.

Not sure why would you care. These should be value objects, so they
should keep no state and as such it shouldn't matter when they are
generated and how many of them.

> However, that is not an issue created by using a defined structure for
> the annotation result.  The RFC currently says it returns an associative
> array, aka anonymous struct.  Those are always highly mutable.  A
> classed object is as mutable as its design allows it to be.  To wit:

As far as I can see, the RFC says it would return an array of RFC nodes.
Now, it is true that array itself is mutable, we don't have immutable
containers really, but that's not what I meant. The AST Node should not
be really mutable.

> <<__Annotation>>
> class Definition {
>   protected $foo;
>   protected $bar;
>   public function getFoo() {}
>   public function getBar() {}
> }

Except for definitions of $foo and $bar - for which I don't see much use
- this is exactly what I proposed, only as a class and not interface.
I've already explained why interface is better :)

> <<Definition(foo => 1, bar => 2)>>

Again, here we have named arguments problem. Note that you're using
diffrent syntax for named arguments than last time :)
-- 
Stas Malyshev
smalyshev@gmail.com