Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:92961 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46009 invoked from network); 29 Apr 2016 21:30:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Apr 2016 21:30:42 -0000 Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error) X-PHP-List-Original-Sender: anatol.php@belski.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:32925] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1F/DB-26386-D72D3275 for ; Fri, 29 Apr 2016 17:30:38 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id CA13A782D10; Fri, 29 Apr 2016 23:30:34 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on h1123647.serverkompetenz.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.5 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from w530phpdev (pD9FD2DCF.dip0.t-ipconnect.de [217.253.45.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id 1FA26782D0C; Fri, 29 Apr 2016 23:30:28 +0200 (CEST) To: "'Davey Shafik'" , "'Pierrick Charron'" Cc: "'PHP internals'" , References: <059601d1a050$90fa0fb0$b2ee2f10$@belski.net> <068e01d1a09a$c465f900$4d31eb00$@belski.net> <06b201d1a0a5$9d446bd0$d7cd4370$@belski.net> In-Reply-To: Date: Fri, 29 Apr 2016 23:30:24 +0200 Message-ID: <02a601d1a25e$59821d60$0c865820$@belski.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQF2BKo8D2vu994Tl7FnqIFtyzRlYQG/Hr9vAjr6KeMBmS8sawGNjjyAAUuXehMCEfDDpgJdJT/lAl1OeC0BXndQ0J/T9meQ Content-Language: en-us Subject: RE: [PHP-DEV] Re: ext/curl update From: anatol.php@belski.net ("Anatol Belski") Hi Davey, > -----Original Message----- > From: me@daveyshafik.com [mailto:me@daveyshafik.com] On Behalf Of = Davey > Shafik > Sent: Thursday, April 28, 2016 11:30 PM > To: Pierrick Charron > Cc: Anatol Belski ; PHP internals > ; pajoye@php.net > Subject: Re: [PHP-DEV] Re: ext/curl update >=20 > I seem to have created some confusion here: >=20 > The reason _my_ patch for Server Push isn't merged is tests for it = were > requested and are blocking it. I'm not saying tests for these = constants should be > added. >=20 Yes, I was also reading this, that the "tests" was related to your PR. = Cleared out now, anyway. Regards anatol > - Davey >=20 > On Wed, Apr 27, 2016 at 4:15 PM, Pierrick Charron = wrote: >=20 > > Sorry for the 2 mails but I forgot to give you the URL : > > > > https://github.com/php/php-src/pull/1890/files > > > > On 27 April 2016 at 19:14, Pierrick Charron = wrote: > > > >> Hi Anatol, > >> > >> I created a new patch from the one first published but this time = this > >> one target 7.0 and only expose new constants to that do not require > >> any logic on the extension side. > >> These constants are just exposed if they are available in the = version > >> installed and are bridge in the curl_setop function. > >> > >> If that's OK I'll commit this on 7.0 and merge it also on master. > >> Then I'll work on adding new things that require logic and clean > >> those for 7.1 and add tests if possible. > >> > >> Regards > >> Pierrick > >> > >> On 27 April 2016 at 12:55, Anatol Belski = wrote: > >> > >>> > >>> > >>> > -----Original Message----- > >>> > From: pierrick@webstart.fr [mailto:pierrick@webstart.fr] On = Behalf > >>> > Of > >>> Pierrick > >>> > Charron > >>> > Sent: Wednesday, April 27, 2016 6:20 PM > >>> > To: Anatol Belski > >>> > Cc: Davey Shafik ; PHP internals < > >>> internals@lists.php.net>; > >>> > pajoye@php.net > >>> > Subject: Re: [PHP-DEV] Re: ext/curl update > >>> > > >>> > Yep I'll check if I can add some test that could be easy to > >>> > implement > >>> using > >>> > curl_easy_getinfo or using the php local server. Otherwise not > >>> > sure we > >>> could > >>> > easily compile PHP with all those libcurl versions... > >>> > > >>> > > >>> > On 27 April 2016 at 11:37, Anatol Belski >>> > > wrote: > >>> > > >>> > > >>> > Hi, > >>> > > >>> > > -----Original Message----- > >>> > > From: pierrick@webstart.fr > >>> > [mailto:pierrick@webstart.fr ] On > >>> Behalf Of > >>> > Pierrick > >>> > > Charron > >>> > > Sent: Wednesday, April 27, 2016 2:20 PM > >>> > > To: Anatol Belski >>> > > > >>> > > Cc: Davey Shafik = >; > >>> > PHP internals >; > >>> > > pajoye@php.net > >>> > > Subject: Re: [PHP-DEV] Re: ext/curl update > >>> > > > >>> > > I agree, but I don't really now how I could test those > >>> > things > >>> since they > >>> > almost all > >>> > > of the time only affect how libcurl will handle the > >>> request/cache and > >>> > we have no > >>> > > way to retrieve options like curl_easy_getopt or = something > >>> similar. > >>> > > > >>> > > On 27 April 2016 at 02:46, Anatol Belski < > >>> anatol.php@belski.net > >>> > > >>> > > >>> > > >>> > > > >>> > wrote: > >>> > > > >>> > > > >>> > > Hi, > >>> > > > >>> > > > -----Original Message----- > >>> > > > From: me@daveyshafik.com = > >>> > > > >>> > > [mailto:me@daveyshafik.com > >>> > > ] On > >>> > Behalf > >>> Of > >>> > > Davey > >>> > > > Shafik > >>> > > > Sent: Sunday, April 24, 2016 2:25 AM > >>> > > > To: Pierrick Charron >>> > >>> > > > > >>> > > > Cc: PHP internals >>> > > >>> > > >>> > > >>> internals@lists.php.net> > >; > >>> > pajoye@php.net >>> > > > >>> > > > Subject: [PHP-DEV] Re: ext/curl update > >>> > > > > >>> > > > Hi Pierrick, > >>> > > > > >>> > > > This should be in master for 7.1, alongside my = RFC'ed > >>> patch for > >>> > server > >>> > > push > >>> > > > support. > >>> > > > > >>> > > > You emailed me directly about the aforementioned = patch > >>> so I'll > >>> > just > >>> > > respond > >>> > > > here as it's relevant: > >>> > > > > >>> > > > The patch should hit in 7.1 but it has been = requested > >>> that tests be > >>> > > added =E2=80=94 and > >>> > > > we can't add tests with a server push supporting > >>> HTTP/2 server > >>> > against > >>> > > which to > >>> > > > push. > >>> > > > > >>> > > As from the patch, many constants have nothing to = do > >>> with HTTP/2 > >>> > > implementation and add just name/value without any = further > >>> logic. If > >>> > there were > >>> > > a reduced patch with only such cases, it would be > >>> > acceptable > >>> for 7.0 > >>> > as well and > >>> > > there were probably no collisions expected. What do you = think? > >>> > > > >>> > > >>> > So far I understood tests are exactly about HTTP2. Not = sure > >>> > how > >>> you > >>> > would tests all the constants present in libcurl. Would need to > >>> rebuild with a > >>> > dozen libcurl versions, but the documentation and compile time > >>> > version > >>> check > >>> > are already reliable things. > >>> > > >>> But if you can fish out only the cases with name/value which don't > >>> interfere with the HTTP2 work, so it's fine to add. OFC it were > >>> absurd to recompile with all libcurl versions :) especially as an > >>> excellent documentation to every option is presend on the cURL = side. > >>> If that's only an option that say affects the curl behavior and > >>> don't require any extra handling, I don't think it is critical. On > >>> the other hand, if an option requires some pre/post handling an = thus > >>> some extra implementation - then OFC it should be urgently = suggested to > have a good test. > >>> > >>> Thanks > >>> > >>> Anatol > >>> > >>> > >> > >