Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:92906 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8653 invoked from network); 28 Apr 2016 21:30:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Apr 2016 21:30:26 -0000 Authentication-Results: pb1.pair.com smtp.mail=me@daveyshafik.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=me@daveyshafik.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.215.47 cause and error) X-PHP-List-Original-Sender: me@daveyshafik.com X-Host-Fingerprint: 209.85.215.47 mail-lf0-f47.google.com Received: from [209.85.215.47] ([209.85.215.47:34385] helo=mail-lf0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5F/10-28296-EE082275 for ; Thu, 28 Apr 2016 17:30:25 -0400 Received: by mail-lf0-f47.google.com with SMTP id j11so111710861lfb.1 for ; Thu, 28 Apr 2016 14:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daveyshafik-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=IKbyOV1SEAzfitYlTkkzGWRPSoC1itx49EnwXxPQ7+4=; b=oe7QPdfgNGQsT4MJU7ZUPs2ODZf/bjTw1vs2GvOWSUb5O9vpFD5Rzv1+kGtvUh2H0+ H2Q1u46vMAlo6cF/rqjjVBKLOA6+91Kd4L8WuMCVDeM9POhdtoEadsOcK7P/njannjoe ES3TZgOgI/ICONillzP0kvRIt3jQgYm+3+b9PYCg1hIWFr9FlCX7kJTSdN4UiGP3AtNS hRAOGA7D8OWgZPlGBmtSZF51RzJD4ZrlNdleLnh6le731/ISIv3ibbHFBWNIAEzNPifg 3UHy7xaqQJuoaIfxt+q/O9rvfhd62vAhGE2TlALZ2JElnu/ErKG3vsg6DBjh/7yt0ann WX1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=IKbyOV1SEAzfitYlTkkzGWRPSoC1itx49EnwXxPQ7+4=; b=XT/iTbji3x/JgS5zYLT0/t29L+6P/Bj45kGdTBF+dk5JmZ2Don3E26CwWHbXxXTyc8 Xyx+3zSYQGgwBRgrPI3pHC6EUdnDr4oxTPfLGlZBAtGOBONFaWnEgY5mIbxFQPVG4jJp qKINlN2J0M9f6inM3C7KE2ttz9mq6uwIqlEz3+n7V1bi80RqYX6UbFGevX0T/jFBkqgC MjQ6iK5MVHLBlinJVf3pAnzss4IO1qoYpTuAJwYzNYgXNNUeZ9o4MZvP38dBTCeizKfw izvNOt3/srE2EKzZSxI+NFmeAJYpHOVTMwoZ9xKw7HKhHuT0Mi8gafGZimWzB9KGaU5S 6hdw== X-Gm-Message-State: AOPr4FVa+oL8x4b8LP5ecRtYC8UZa+lR0/6KKHhZuo66sWsfOMU1uM6PXut6WOG3CnW+NjYwQpMtkqtuiNbQ3Qch MIME-Version: 1.0 X-Received: by 10.25.169.144 with SMTP id s138mr7365507lfe.108.1461879018461; Thu, 28 Apr 2016 14:30:18 -0700 (PDT) Sender: me@daveyshafik.com Received: by 10.25.28.10 with HTTP; Thu, 28 Apr 2016 14:30:18 -0700 (PDT) In-Reply-To: References: <059601d1a050$90fa0fb0$b2ee2f10$@belski.net> <068e01d1a09a$c465f900$4d31eb00$@belski.net> <06b201d1a0a5$9d446bd0$d7cd4370$@belski.net> Date: Thu, 28 Apr 2016 14:30:18 -0700 X-Google-Sender-Auth: 3DNN36UZHIHQ49NJHigUjFxzzXg Message-ID: To: Pierrick Charron Cc: Anatol Belski , PHP internals , pajoye@php.net Content-Type: multipart/alternative; boundary=001a11402fa699ba190531923b3a Subject: Re: [PHP-DEV] Re: ext/curl update From: davey@php.net (Davey Shafik) --001a11402fa699ba190531923b3a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I seem to have created some confusion here: The reason _my_ patch for Server Push isn't merged is tests for it were requested and are blocking it. I'm not saying tests for these constants should be added. - Davey On Wed, Apr 27, 2016 at 4:15 PM, Pierrick Charron wrote= : > Sorry for the 2 mails but I forgot to give you the URL : > > https://github.com/php/php-src/pull/1890/files > > On 27 April 2016 at 19:14, Pierrick Charron wrote: > >> Hi Anatol, >> >> I created a new patch from the one first published but this time this on= e >> target 7.0 and only expose new constants to that do not require any logi= c >> on the extension side. >> These constants are just exposed if they are available in the version >> installed and are bridge in the curl_setop function. >> >> If that's OK I'll commit this on 7.0 and merge it also on master. Then >> I'll work on adding new things that require logic and clean those for 7.= 1 >> and add tests if possible. >> >> Regards >> Pierrick >> >> On 27 April 2016 at 12:55, Anatol Belski wrote: >> >>> >>> >>> > -----Original Message----- >>> > From: pierrick@webstart.fr [mailto:pierrick@webstart.fr] On Behalf Of >>> Pierrick >>> > Charron >>> > Sent: Wednesday, April 27, 2016 6:20 PM >>> > To: Anatol Belski >>> > Cc: Davey Shafik ; PHP internals < >>> internals@lists.php.net>; >>> > pajoye@php.net >>> > Subject: Re: [PHP-DEV] Re: ext/curl update >>> > >>> > Yep I'll check if I can add some test that could be easy to implement >>> using >>> > curl_easy_getinfo or using the php local server. Otherwise not sure w= e >>> could >>> > easily compile PHP with all those libcurl versions... >>> > >>> > >>> > On 27 April 2016 at 11:37, Anatol Belski >> > > wrote: >>> > >>> > >>> > Hi, >>> > >>> > > -----Original Message----- >>> > > From: pierrick@webstart.fr >>> > [mailto:pierrick@webstart.fr ] On >>> Behalf Of >>> > Pierrick >>> > > Charron >>> > > Sent: Wednesday, April 27, 2016 2:20 PM >>> > > To: Anatol Belski >> > > >>> > > Cc: Davey Shafik >; PHP >>> > internals >= ; >>> > > pajoye@php.net >>> > > Subject: Re: [PHP-DEV] Re: ext/curl update >>> > > >>> > > I agree, but I don't really now how I could test those things >>> since they >>> > almost all >>> > > of the time only affect how libcurl will handle the >>> request/cache and >>> > we have no >>> > > way to retrieve options like curl_easy_getopt or something >>> similar. >>> > > >>> > > On 27 April 2016 at 02:46, Anatol Belski < >>> anatol.php@belski.net >>> > >>> > > >>> > > >>> > wrote: >>> > > >>> > > >>> > > Hi, >>> > > >>> > > > -----Original Message----- >>> > > > From: me@daveyshafik.com >>> > > >>> > > [mailto:me@daveyshafik.com >>> > > ] On Behalf >>> Of >>> > > Davey >>> > > > Shafik >>> > > > Sent: Sunday, April 24, 2016 2:25 AM >>> > > > To: Pierrick Charron >> > >> > > > >>> > > > Cc: PHP internals >> > >>> > >>> > > >> internals@lists.php.net> > >; >>> > pajoye@php.net >> > > >>> > > > Subject: [PHP-DEV] Re: ext/curl update >>> > > > >>> > > > Hi Pierrick, >>> > > > >>> > > > This should be in master for 7.1, alongside my RFC'ed >>> patch for >>> > server >>> > > push >>> > > > support. >>> > > > >>> > > > You emailed me directly about the aforementioned patc= h >>> so I'll >>> > just >>> > > respond >>> > > > here as it's relevant: >>> > > > >>> > > > The patch should hit in 7.1 but it has been requested >>> that tests be >>> > > added =E2=80=94 and >>> > > > we can't add tests with a server push supporting >>> HTTP/2 server >>> > against >>> > > which to >>> > > > push. >>> > > > >>> > > As from the patch, many constants have nothing to do >>> with HTTP/2 >>> > > implementation and add just name/value without any further >>> logic. If >>> > there were >>> > > a reduced patch with only such cases, it would be acceptable >>> for 7.0 >>> > as well and >>> > > there were probably no collisions expected. What do you think= ? >>> > > >>> > >>> > So far I understood tests are exactly about HTTP2. Not sure how >>> you >>> > would tests all the constants present in libcurl. Would need to >>> rebuild with a >>> > dozen libcurl versions, but the documentation and compile time versio= n >>> check >>> > are already reliable things. >>> > >>> But if you can fish out only the cases with name/value which don't >>> interfere with the HTTP2 work, so it's fine to add. OFC it were absurd = to >>> recompile with all libcurl versions :) especially as an excellent >>> documentation to every option is presend on the cURL side. If that's on= ly >>> an option that say affects the curl behavior and don't require any extr= a >>> handling, I don't think it is critical. On the other hand, if an option >>> requires some pre/post handling an thus some extra implementation - the= n >>> OFC it should be urgently suggested to have a good test. >>> >>> Thanks >>> >>> Anatol >>> >>> >> > --001a11402fa699ba190531923b3a--