Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:92856 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65448 invoked from network); 27 Apr 2016 23:15:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Apr 2016 23:15:26 -0000 Authentication-Results: pb1.pair.com header.from=pierrick@webstart.fr; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=pierrick@webstart.fr; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain webstart.fr from 209.85.161.174 cause and error) X-PHP-List-Original-Sender: pierrick@webstart.fr X-Host-Fingerprint: 209.85.161.174 mail-yw0-f174.google.com Received: from [209.85.161.174] ([209.85.161.174:32845] helo=mail-yw0-f174.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8E/CD-20013-10841275 for ; Wed, 27 Apr 2016 19:15:16 -0400 Received: by mail-yw0-f174.google.com with SMTP id t10so104713147ywa.0 for ; Wed, 27 Apr 2016 16:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=webstart-fr.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=dkKITfcGMVWdYRiVrv6AwGWaAqZCzIgk6Bzni5xWwI4=; b=G0s8xJuPOXDh2hzTS96iY6A6zIldQyORo7OkIOaBC3pkBFvg0Q1x6wkyuegSiDBb+Y L8xoINCFPKkonMb3tYK0zhddSlih8mCE79C7WfV7rmI3LaFEYPihiPJtyaPenQJUqX4N GVM7Hg/+9COp6BiROJtmLjyN4/qNV5RyF9O57ZkJnt75JpcJha4RfOqEXqucvgjrCjoz /EY33aGa8CI/ddguxmKVI7fr6keqx1kObB7ti2LnvQuv7pQd/9Rj8IJEZOJX2wyDU8o9 CBP9Smbo5joRdwOQ0lkiymAk12stFpnbIuCckZttdojVC+tOEDxIfUAPmf2gvqp3yNTl 4LJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=dkKITfcGMVWdYRiVrv6AwGWaAqZCzIgk6Bzni5xWwI4=; b=DA5BRdjjV4lL62Pi5jmeq8b9tqESphkuEypwqJYpzYm7/HKrZKL5HdPA5dwUlMcmX3 u/EJch/OEI9QIKBayBlrvqC1bVZkYHKazRkPuJ4tMLBI9VRgfsmhxxBitNtkGB7u5mi7 FbxZAM9j8UB1iHJdmb7jM0cm3FXY/gvyOFAluDwg8uxj4MoRDUGLPPx5Hwgc50398+VL YGnk+aXM6rJYz/Bvh+XDMVqQLV9v/P6TewaJADd3DE5Bp71+urWAQwe+R1VeoY+Qv/YB Ais8DsptAncTzhzUhkl7JDS82BBdfxOg8kEb8PnrVureHxMGIisYi9Kno1cFN59AMxRM 0z9A== X-Gm-Message-State: AOPr4FXMWzjYomYA0z/BCW+a1BTfpdKk+IDTLkL04DUpMLCn/wfCerISwNMEb6+fghBcJGt8BzdteYP6y0/CQw== MIME-Version: 1.0 X-Received: by 10.37.28.86 with SMTP id c83mr6382275ybc.70.1461798906498; Wed, 27 Apr 2016 16:15:06 -0700 (PDT) Sender: pierrick@webstart.fr Received: by 10.37.81.7 with HTTP; Wed, 27 Apr 2016 16:15:06 -0700 (PDT) In-Reply-To: References: <059601d1a050$90fa0fb0$b2ee2f10$@belski.net> <068e01d1a09a$c465f900$4d31eb00$@belski.net> <06b201d1a0a5$9d446bd0$d7cd4370$@belski.net> Date: Wed, 27 Apr 2016 19:15:06 -0400 X-Google-Sender-Auth: bFFrkL7qBcfTCsEkSu0GILnSNcw Message-ID: To: Anatol Belski Cc: Davey Shafik , PHP internals , pajoye@php.net Content-Type: multipart/alternative; boundary=001a114258488e658b05317f9488 Subject: Re: [PHP-DEV] Re: ext/curl update From: pierrick@adoy.net (Pierrick Charron) --001a114258488e658b05317f9488 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sorry for the 2 mails but I forgot to give you the URL : https://github.com/php/php-src/pull/1890/files On 27 April 2016 at 19:14, Pierrick Charron wrote: > Hi Anatol, > > I created a new patch from the one first published but this time this one > target 7.0 and only expose new constants to that do not require any logic > on the extension side. > These constants are just exposed if they are available in the version > installed and are bridge in the curl_setop function. > > If that's OK I'll commit this on 7.0 and merge it also on master. Then > I'll work on adding new things that require logic and clean those for 7.1 > and add tests if possible. > > Regards > Pierrick > > On 27 April 2016 at 12:55, Anatol Belski wrote: > >> >> >> > -----Original Message----- >> > From: pierrick@webstart.fr [mailto:pierrick@webstart.fr] On Behalf Of >> Pierrick >> > Charron >> > Sent: Wednesday, April 27, 2016 6:20 PM >> > To: Anatol Belski >> > Cc: Davey Shafik ; PHP internals < >> internals@lists.php.net>; >> > pajoye@php.net >> > Subject: Re: [PHP-DEV] Re: ext/curl update >> > >> > Yep I'll check if I can add some test that could be easy to implement >> using >> > curl_easy_getinfo or using the php local server. Otherwise not sure we >> could >> > easily compile PHP with all those libcurl versions... >> > >> > >> > On 27 April 2016 at 11:37, Anatol Belski > > > wrote: >> > >> > >> > Hi, >> > >> > > -----Original Message----- >> > > From: pierrick@webstart.fr >> > [mailto:pierrick@webstart.fr ] On Behalf >> Of >> > Pierrick >> > > Charron >> > > Sent: Wednesday, April 27, 2016 2:20 PM >> > > To: Anatol Belski > > > >> > > Cc: Davey Shafik >; PHP >> > internals >; >> > > pajoye@php.net >> > > Subject: Re: [PHP-DEV] Re: ext/curl update >> > > >> > > I agree, but I don't really now how I could test those things >> since they >> > almost all >> > > of the time only affect how libcurl will handle the >> request/cache and >> > we have no >> > > way to retrieve options like curl_easy_getopt or something >> similar. >> > > >> > > On 27 April 2016 at 02:46, Anatol Belski > > >> > > > >> > >> > wrote: >> > > >> > > >> > > Hi, >> > > >> > > > -----Original Message----- >> > > > From: me@daveyshafik.com >> > > >> > > [mailto:me@daveyshafik.com >> > > ] On Behalf O= f >> > > Davey >> > > > Shafik >> > > > Sent: Sunday, April 24, 2016 2:25 AM >> > > > To: Pierrick Charron > > > > > > >> > > > Cc: PHP internals > > >> > >> > > >> > >; >> > pajoye@php.net > > > >> > > > Subject: [PHP-DEV] Re: ext/curl update >> > > > >> > > > Hi Pierrick, >> > > > >> > > > This should be in master for 7.1, alongside my RFC'ed >> patch for >> > server >> > > push >> > > > support. >> > > > >> > > > You emailed me directly about the aforementioned patch >> so I'll >> > just >> > > respond >> > > > here as it's relevant: >> > > > >> > > > The patch should hit in 7.1 but it has been requested >> that tests be >> > > added =E2=80=94 and >> > > > we can't add tests with a server push supporting HTTP/= 2 >> server >> > against >> > > which to >> > > > push. >> > > > >> > > As from the patch, many constants have nothing to do wit= h >> HTTP/2 >> > > implementation and add just name/value without any further >> logic. If >> > there were >> > > a reduced patch with only such cases, it would be acceptable >> for 7.0 >> > as well and >> > > there were probably no collisions expected. What do you think? >> > > >> > >> > So far I understood tests are exactly about HTTP2. Not sure how >> you >> > would tests all the constants present in libcurl. Would need to rebuil= d >> with a >> > dozen libcurl versions, but the documentation and compile time version >> check >> > are already reliable things. >> > >> But if you can fish out only the cases with name/value which don't >> interfere with the HTTP2 work, so it's fine to add. OFC it were absurd t= o >> recompile with all libcurl versions :) especially as an excellent >> documentation to every option is presend on the cURL side. If that's onl= y >> an option that say affects the curl behavior and don't require any extra >> handling, I don't think it is critical. On the other hand, if an option >> requires some pre/post handling an thus some extra implementation - then >> OFC it should be urgently suggested to have a good test. >> >> Thanks >> >> Anatol >> >> > --001a114258488e658b05317f9488--