Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92842
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain webstart.fr from 209.85.161.175 cause and error)
MIME-Version: 1.0
Sender: pierrick@webstart.fr
In-Reply-To: <068e01d1a09a$c465f900$4d31eb00$@belski.net>
References: <CAOfKkdT1WVFCYTC9A7=AvWy=odsgAc-dKRwXawEeorQhz1=08w@mail.gmail.com>
	<CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>
	<059601d1a050$90fa0fb0$b2ee2f10$@belski.net>
	<CAOfKkdQY5gSVfcsWC9-Wxjj37sSwoiD5e=sG8XSiWj-fXSZ8Hg@mail.gmail.com>
	<068e01d1a09a$c465f900$4d31eb00$@belski.net>
Date: Wed, 27 Apr 2016 12:19:37 -0400
Message-ID: <CAOfKkdQdCEgiXCdJnk2DAbcqEfAPdpZuo+dcPFJo+NOaj6-Zsw@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Davey Shafik <davey@php.net>, PHP internals <internals@lists.php.net>, pajoye@php.net
Content-Type: multipart/alternative; boundary=001a114f0e8aaa7d86053179c69d
Subject: Re: [PHP-DEV] Re: ext/curl update
From: pierrick@adoy.net (Pierrick Charron)

--001a114f0e8aaa7d86053179c69d
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Yep I'll check if I can add some test that could be easy to implement using
curl_easy_getinfo or using the php local server. Otherwise not sure we
could easily compile PHP with all those libcurl versions...


On 27 April 2016 at 11:37, Anatol Belski <anatol.php@belski.net> wrote:

> Hi,
>
> > -----Original Message-----
> > From: pierrick@webstart.fr [mailto:pierrick@webstart.fr] On Behalf Of
> Pierrick
> > Charron
> > Sent: Wednesday, April 27, 2016 2:20 PM
> > To: Anatol Belski <anatol.php@belski.net>
> > Cc: Davey Shafik <davey@php.net>; PHP internals <internals@lists.php.ne=
t
> >;
> > pajoye@php.net
> > Subject: Re: [PHP-DEV] Re: ext/curl update
> >
> > I agree, but I don't really now how I could test those things since the=
y
> almost all
> > of the time only affect how libcurl will handle the request/cache and w=
e
> have no
> > way to retrieve options like curl_easy_getopt or something similar.
> >
> > On 27 April 2016 at 02:46, Anatol Belski <anatol.php@belski.net
> > <mailto:anatol.php@belski.net> > wrote:
> >
> >
> >       Hi,
> >
> >       > -----Original Message-----
> >       > From: me@daveyshafik.com <mailto:me@daveyshafik.com>
> > [mailto:me@daveyshafik.com <mailto:me@daveyshafik.com> ] On Behalf Of
> > Davey
> >       > Shafik
> >       > Sent: Sunday, April 24, 2016 2:25 AM
> >       > To: Pierrick Charron <pierrick@adoy.net <mailto:
> pierrick@adoy.net> >
> >       > Cc: PHP internals <internals@lists.php.net
> > <mailto:internals@lists.php.net> >; pajoye@php.net <mailto:
> pajoye@php.net>
> >       > Subject: [PHP-DEV] Re: ext/curl update
> >       >
> >       > Hi Pierrick,
> >       >
> >       > This should be in master for 7.1, alongside my RFC'ed patch for
> server
> > push
> >       > support.
> >       >
> >       > You emailed me directly about the aforementioned patch so I'll
> just
> > respond
> >       > here as it's relevant:
> >       >
> >       > The patch should hit in 7.1 but it has been requested that test=
s
> be
> > added =E2=80=94 and
> >       > we can't add tests with a server push supporting HTTP/2 server
> against
> > which to
> >       > push.
> >       >
> >       As from the patch, many constants have nothing to do with HTTP/2
> > implementation and add just name/value without any further logic. If
> there were
> > a reduced patch with only such cases, it would be acceptable for 7.0 as
> well and
> > there were probably no collisions expected. What do you think?
> >
> So far I understood tests are exactly about HTTP2. Not sure how you would
> tests all the constants present in libcurl. Would need to rebuild with a
> dozen libcurl versions, but the documentation and compile time version
> check are already reliable things.
>
> Thanks
>
> anatol
>
>
>

--001a114f0e8aaa7d86053179c69d--