Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92841
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Pierrick Charron'" <pierrick@adoy.net>
Cc: "'Davey Shafik'" <davey@php.net>,
	"'PHP internals'" <internals@lists.php.net>,
	<pajoye@php.net>
References: <CAOfKkdT1WVFCYTC9A7=AvWy=odsgAc-dKRwXawEeorQhz1=08w@mail.gmail.com>	<CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>	<059601d1a050$90fa0fb0$b2ee2f10$@belski.net> <CAOfKkdQY5gSVfcsWC9-Wxjj37sSwoiD5e=sG8XSiWj-fXSZ8Hg@mail.gmail.com>
In-Reply-To: <CAOfKkdQY5gSVfcsWC9-Wxjj37sSwoiD5e=sG8XSiWj-fXSZ8Hg@mail.gmail.com>
Date: Wed, 27 Apr 2016 17:37:50 +0200
Message-ID: <068e01d1a09a$c465f900$4d31eb00$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQF2BKo8D2vu994Tl7FnqIFtyzRlYQG/Hr9vAjr6KeMBmS8sa6AokSVQ
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: ext/curl update
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> -----Original Message-----
> From: pierrick@webstart.fr [mailto:pierrick@webstart.fr] On Behalf Of =
Pierrick
> Charron
> Sent: Wednesday, April 27, 2016 2:20 PM
> To: Anatol Belski <anatol.php@belski.net>
> Cc: Davey Shafik <davey@php.net>; PHP internals =
<internals@lists.php.net>;
> pajoye@php.net
> Subject: Re: [PHP-DEV] Re: ext/curl update
>=20
> I agree, but I don't really now how I could test those things since =
they almost all
> of the time only affect how libcurl will handle the request/cache and =
we have no
> way to retrieve options like curl_easy_getopt or something similar.
>=20
> On 27 April 2016 at 02:46, Anatol Belski <anatol.php@belski.net
> <mailto:anatol.php@belski.net> > wrote:
>=20
>=20
> 	Hi,
>=20
> 	> -----Original Message-----
> 	> From: me@daveyshafik.com <mailto:me@daveyshafik.com>
> [mailto:me@daveyshafik.com <mailto:me@daveyshafik.com> ] On Behalf Of
> Davey
> 	> Shafik
> 	> Sent: Sunday, April 24, 2016 2:25 AM
> 	> To: Pierrick Charron <pierrick@adoy.net <mailto:pierrick@adoy.net> =
>
> 	> Cc: PHP internals <internals@lists.php.net
> <mailto:internals@lists.php.net> >; pajoye@php.net =
<mailto:pajoye@php.net>
> 	> Subject: [PHP-DEV] Re: ext/curl update
> 	>
> 	> Hi Pierrick,
> 	>
> 	> This should be in master for 7.1, alongside my RFC'ed patch for =
server
> push
> 	> support.
> 	>
> 	> You emailed me directly about the aforementioned patch so I'll just
> respond
> 	> here as it's relevant:
> 	>
> 	> The patch should hit in 7.1 but it has been requested that tests be
> added =E2=80=94 and
> 	> we can't add tests with a server push supporting HTTP/2 server =
against
> which to
> 	> push.
> 	>
> 	As from the patch, many constants have nothing to do with HTTP/2
> implementation and add just name/value without any further logic. If =
there were
> a reduced patch with only such cases, it would be acceptable for 7.0 =
as well and
> there were probably no collisions expected. What do you think?
>=20
So far I understood tests are exactly about HTTP2. Not sure how you =
would tests all the constants present in libcurl. Would need to rebuild =
with a dozen libcurl versions, but the documentation and compile time =
version check are already reliable things.

Thanks

anatol