Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92837
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain webstart.fr from 209.85.161.179 cause and error)
MIME-Version: 1.0
Sender: pierrick@webstart.fr
In-Reply-To: <059601d1a050$90fa0fb0$b2ee2f10$@belski.net>
References: <CAOfKkdT1WVFCYTC9A7=AvWy=odsgAc-dKRwXawEeorQhz1=08w@mail.gmail.com>
	<CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>
	<059601d1a050$90fa0fb0$b2ee2f10$@belski.net>
Date: Wed, 27 Apr 2016 08:19:56 -0400
Message-ID: <CAOfKkdQY5gSVfcsWC9-Wxjj37sSwoiD5e=sG8XSiWj-fXSZ8Hg@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Davey Shafik <davey@php.net>, PHP internals <internals@lists.php.net>, pajoye@php.net
Content-Type: multipart/alternative; boundary=94eb2c07b516824c690531766d67
Subject: Re: [PHP-DEV] Re: ext/curl update
From: pierrick@adoy.net (Pierrick Charron)

--94eb2c07b516824c690531766d67
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I agree, but I don't really now how I could test those things since they
almost all of the time only affect how libcurl will handle the
request/cache and we have no way to retrieve options like curl_easy_getopt
or something similar.

On 27 April 2016 at 02:46, Anatol Belski <anatol.php@belski.net> wrote:

> Hi,
>
> > -----Original Message-----
> > From: me@daveyshafik.com [mailto:me@daveyshafik.com] On Behalf Of Davey
> > Shafik
> > Sent: Sunday, April 24, 2016 2:25 AM
> > To: Pierrick Charron <pierrick@adoy.net>
> > Cc: PHP internals <internals@lists.php.net>; pajoye@php.net
> > Subject: [PHP-DEV] Re: ext/curl update
> >
> > Hi Pierrick,
> >
> > This should be in master for 7.1, alongside my RFC'ed patch for server
> push
> > support.
> >
> > You emailed me directly about the aforementioned patch so I'll just
> respond
> > here as it's relevant:
> >
> > The patch should hit in 7.1 but it has been requested that tests be
> added =E2=80=94 and
> > we can't add tests with a server push supporting HTTP/2 server against
> which to
> > push.
> >
> As from the patch, many constants have nothing to do with HTTP/2
> implementation and add just name/value without any further logic. If ther=
e
> were a reduced patch with only such cases, it would be acceptable for 7.0
> as well and there were probably no collisions expected. What do you think=
?
>
> Regards
>
> Anatol
>
>

--94eb2c07b516824c690531766d67--