Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92810
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain telia.com from 81.236.60.156 cause and error)
To: Sara Golemon <pollita@php.net>
References: <CAESVnVpP2xnidOevwcmDHmO4-6LiES1ThegTedOhOqou_Hf3Tw@mail.gmail.com>
 <CAESVnVrvmCPrtP6NXtb7LHeTh+MWOxqowGoBaC9bYnrk_JShLg@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <571FAA37.5070103@telia.com>
Date: Tue, 26 Apr 2016 19:49:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <CAESVnVrvmCPrtP6NXtb7LHeTh+MWOxqowGoBaC9bYnrk_JShLg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Octal overflow detection
From: bjorn.x.larsson@telia.com (=?UTF-8?Q?Bj=c3=b6rn_Larsson?=)

Den 2016-04-19 kl. 01:24, skrev Sara Golemon:
> On Tue, Apr 12, 2016 at 7:38 PM, Sara Golemon <pollita@php.net> wrote:
>> https://wiki.php.net/rfc/octal.overload-checking
>> Because having this expression evaluate to true makes me sad: ("\000"
>> === "\400")
>>
> I haven't heard any responses on this and wanted to bump it back to
> the top of your newsreaders.
>
> For the record, my inclination is to raise a warning on octal
> overflow, but not change behavior (at least, not for 7.1, perhaps
> later).
>
> Note that this warning would bubble up during the lexing phase, so an
> opcache would prevent it from raising on every page load.  That's
> probably fine, the alternative is to signal the parser to bake it into
> the ast output and that's way over-engineered.
>
> -Sara
>
This reminds me a bit about the RFC: 
https://wiki.php.net/rfc/invalid_strings_in_arithmetic.
So an E_WARNING it should be and option 2. In my opinion
no deprecation is needed.

Cheers //Björn