Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92727
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.111.119 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>
References: <BY2PR0201MB178479B3AF8BD49583233034BF6E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <CAESVnVrNqpqsTUCdHiQi8j3d4KVz8ZqRh6pEVJegR-EsmFN3_g@mail.gmail.com>
 <571BA0F0.2030400@fleshgrinder.com> <571C82A7.2060706@fleshgrinder.com>
 <CAEPJdum9BdM2B04d6Jp0_YtD=YZa1pPjUD3H5ZC4RRYkw_t1jA@mail.gmail.com>
 <571CB44C.1000704@fleshgrinder.com>
 <CAEPJdunm-YukXgSV5OWigiWX02Sw9Nz=GvLgJJN4Fq-j-hjZcA@mail.gmail.com>
 <571CBD1E.7020103@fleshgrinder.com> <571DD2A3.2020106@zend.com>
 <CAEZPtU4hdWDHD-z96-sT=d8KEk3bVVrpjMRFbkvQ2Z5QvdNFZg@mail.gmail.com>
 <571DEC9E.80407@zend.com>
 <CAL=_i_=8cLe+8OiBc8=-1GkWCGxEy-n2phhbpfV=n0fSKju-bA@mail.gmail.com>
CC: Pierre Joye <pierre.php@gmail.com>, PHP internals
	<internals@lists.php.net>, Benjamin Eberlei <kontakt@beberlei.de>, Sara
 Golemon <pollita@php.net>
Message-ID: <571E0CF2.4040506@zend.com>
Date: Mon, 25 Apr 2016 15:26:26 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <CAL=_i_=8cLe+8OiBc8=-1GkWCGxEy-n2phhbpfV=n0fSKju-bA@mail.gmail.com>
Content-Type: multipart/alternative;
	boundary="------------030007070608040401090306"
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2016 12:26:40.7668 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1780
Subject: Re: [PHP-DEV] [RFC] PHP Attributes
From: dmitry@zend.com (Dmitry Stogov)

--------------030007070608040401090306
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit



On 04/25/2016 02:28 PM, Joe Watkins wrote:
> Morning internals,
>
>     This morning I attempted to prototype a dbc extension.
>
>     In my opinion, the patch, or internals, are not fit for the 
> intended purpose.
>
>     At the moment, the *only* way to perform meta programming is going 
> to be in userland. This is going to make it prohibitively slow, and 
> rather pointless.

why? It's quite easy to use attributes in C extension.

if (op_array->attributes) {
     zval *val = zend_hash_find_str(op_array->attributes, "requires", 
sizeof("requires")-1_;
     if (val && Z_TYPE_P(val) == IS_ARRAY) {
       HashTable *ht = Z_ARRVAL_P(val);
       ZEND_HASH_FORECH_VAL(ht, val) {
         ...
       ZEND_HASH_FOREACH_END();
    }
}


>
>     None of the compiler API is exported: This means that AST is 
> almost useless to internals unless it's a constant expression.
Do you mean C or PHP API?
What exactly do you like to be exported? zend_compile_expr()? It's not a 
problem to export it in 7.1.

>
>     There is a problem with zend extensions and fcall handlers, which 
> we are not sure how to fix.

This is completely unrelated historical problem  :)
>
>     Working with AST is easy, working with opcodes directly is not.
>
>     Before we can have this, we must work on the AST API and allow 
> extensions to transform AST with much better hooks than we have at the 
> moment.
This is related to user extendable parser, that is definitely not a 
subject of this RFC.

>
>     I was excited to start working with this .. at the moment, I'm -1.

I got you.
Attributes are not especially for DbC and user extendable parser, and 
they are not a magic wand.
They may be an underlying layer for many things (including DbC).
But to reach what you want, you'll have to start from something anyway.

Thanks. Dmitry.
>
> Cheers
> Joe
>
> PS. If anyone is interested http://github.com/krakjoe/dbc was my first 
> attempt at interacting with the patch.
>
>
>
>
> On Mon, Apr 25, 2016 at 11:08 AM, Dmitry Stogov <dmitry@zend.com 
> <mailto:dmitry@zend.com>> wrote:
>
>
>
>     On 04/25/2016 12:44 PM, Pierre Joye wrote:
>
>         hi Dmitry,
>
>         Awesome work! Thanks.
>
>         I do like you keep what was discussed last time. Make the basics
>         available and leave the rest to the applications (doctrine or
>         other).
>
>         I feel too that how the apps will interact with may need some more
>         discussions but other commented on it so I won't interfer here :).
>
>     I've collected the most interesting feedback at
>     https://wiki.php.net/rfc/attributes#open_issues
>     And I'm going to correct RFC and implementation rethinking these
>     questions.
>
>     Thanks. Dmitry.
>
>
>
>         On Mon, Apr 25, 2016 at 3:17 PM, Dmitry Stogov
>         <dmitry@zend.com <mailto:dmitry@zend.com>> wrote:
>
>             The proposed by you "@..." syntax just won't fit into PHP
>             grammar, because @
>             used as silence operator.
>
>             Attribute, syntax is taken from HHVM. I don't see a big
>             reason to introduce
>             more fragmentation into PHP world.
>
>         Also see https://docs.hhvm.com/hack/attributes/syntax and I fully
>         agree with Dmitry here. It makes no sense now to go with our own
>         syntax.
>
>         If any of the hhvm developers are around, we may get some
>         feedbacks
>         about their current APIs (using getAttributes) and if they
>         would like
>         to change one thing or another. That could (or must) part of
>         the PHP
>         specifications.
>
>         Cheers,
>
>
>
>     -- 
>     PHP Internals - PHP Runtime Development Mailing List
>     To unsubscribe, visit: http://www.php.net/unsub.php
>
>


--------------030007070608040401090306--