Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92725
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.46 as permitted sender)
MIME-Version: 1.0
References: <CAOfKkdT1WVFCYTC9A7=AvWy=odsgAc-dKRwXawEeorQhz1=08w@mail.gmail.com>
 <CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>
In-Reply-To: <CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>
Date: Mon, 25 Apr 2016 11:31:48 +0000
Message-ID: <CAPwsocFt0TJiD-D2xbqPcjEMZYA7+y6608GEnrxxgpjVK-EFEg@mail.gmail.com>
To: Davey Shafik <davey@php.net>, Pierrick Charron <pierrick@adoy.net>
Cc: PHP internals <internals@lists.php.net>, pajoye@php.net
Content-Type: multipart/alternative; boundary=001a113ff8f039b6a805314d86c0
Subject: Re: [PHP-DEV] Re: ext/curl update
From: leight@gmail.com (Leigh)

--001a113ff8f039b6a805314d86c0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, 24 Apr 2016 at 01:25 Davey Shafik <davey@php.net> wrote:

> Hi Pierrick,
>
> This should be in master for 7.1, alongside my RFC'ed patch for server pu=
sh
> support.


I don't see why the additional constants that don't have a direct
dependency on your server push patch can't be committed to 7.0 as well. The
patch is pretty non-invasive.

The patch should hit in 7.1 but it has been requested that tests be added =
=E2=80=94
> and we can't add tests with a server push supporting HTTP/2 server agains=
t
> which to push.
>

The only new logic seems to be around CURLMOPT_PIPELINING_*_BL
and CURLOPT_STREAM_DEPENDS(_E). I don't know what these do, are they
related to server push? Is it possible to add deterministic tests for them?

Maybe in 7.1 we could bump the minimum version of cURL required too. #ifdef
version checks going back over 12 years seems unnecessary :)

--001a113ff8f039b6a805314d86c0--