Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92672
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain webstart.fr from 209.85.161.176 cause and error)
MIME-Version: 1.0
Sender: pierrick@webstart.fr
In-Reply-To: <CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>
References: <CAOfKkdT1WVFCYTC9A7=AvWy=odsgAc-dKRwXawEeorQhz1=08w@mail.gmail.com>
	<CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>
Date: Sat, 23 Apr 2016 23:03:30 -0400
Message-ID: <CAOfKkdRBek9eucyAURQj+rhTpSVmMkbiMB=A1Sn=iNy3uHk1ew@mail.gmail.com>
To: Davey Shafik <davey@php.net>
Cc: PHP internals <internals@lists.php.net>, pajoye@php.net
Content-Type: multipart/alternative; boundary=001a11408064fd92f80531324d05
Subject: Re: ext/curl update
From: pierrick@adoy.net (Pierrick Charron)

--001a11408064fd92f80531324d05
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Davey,

Thanks for your answer. I still have small projects on my pipeline that I
want to finish but I'll start looking at libnghttp2 and if I get some time
I'll recontact you to maybe help you on remaining tasks :-) Do you have
specifics stuffs that you would like me to look at ?

About the patch if there is no objection i'll commit it to the 7.1 branch
soon.

Pierrick

On 23 April 2016 at 20:24, Davey Shafik <davey@php.net> wrote:

> Hi Pierrick,
>
> This should be in master for 7.1, alongside my RFC'ed patch for server
> push support.
>
> You emailed me directly about the aforementioned patch so I'll just
> respond here as it's relevant:
>
> The patch should hit in 7.1 but it has been requested that tests be added
> =E2=80=94 and we can't add tests with a server push supporting HTTP/2 ser=
ver
> against which to push.
>
> I'm working with Pierre Joye (CC'ed) to try and update the cli-server to
> use libnghttp2 to turn it into a fully fledged HTTP/2 compliant server wi=
th
> support for server push and things like multiplexing (see:
> http://wiki.php.net/rfc/cli_server_http2). Curl also uses libnghttp2 for
> it's HTTP/2 support.
>
> I hope to eventually (7.2+) use libnghttp2 to add an ext/nghttp2 HTTP
> client and update the HTTP streams layer to support HTTP/2 also.
>
> I'd welcome your collaboration on any of this.
>
> - Davey
>
> On Sat, Apr 23, 2016 at 12:30 PM, Pierrick Charron <pierrick@adoy.net>
> wrote:
>
>> Hi internals,
>>
>> I took some time to add some easy to implement new "features" that were
>> implemented in libcurl but missing in ext/curl. Most of them are just
>> exposing a new constant in ext/curl and dispatched in the curl_setopt
>> function. I created a branch over master but the patch is applicable
>> without conflict the 7.0 branch.
>>
>> https://github.com/php/php-src/compare/master...adoy:curl-update
>>
>> I was wondering since it's not a big patch and it only introduce new
>> constants :
>>
>> - Should I commit this patch to 7.0 and master or only master
>> - Should I do a RFC to include this patch ?
>>
>> Thanks for your feedback
>> Pierrick
>>
>>
>>
>>
>>
>>
>>
>

--001a11408064fd92f80531324d05--