Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92670
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.217.175 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <CAOfKkdT1WVFCYTC9A7=AvWy=odsgAc-dKRwXawEeorQhz1=08w@mail.gmail.com>
References: <CAOfKkdT1WVFCYTC9A7=AvWy=odsgAc-dKRwXawEeorQhz1=08w@mail.gmail.com>
Date: Sat, 23 Apr 2016 17:24:46 -0700
Message-ID: <CANaX5ncVk2L6W4fvDjsD8YWLodoq8gOZ4tMOR5AzdWSEaRVxSw@mail.gmail.com>
To: Pierrick Charron <pierrick@adoy.net>
Cc: PHP internals <internals@lists.php.net>, pajoye@php.net
Content-Type: multipart/alternative; boundary=e89a8f6427225996d40531301664
Subject: Re: ext/curl update
From: davey@php.net (Davey Shafik)

--e89a8f6427225996d40531301664
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Pierrick,

This should be in master for 7.1, alongside my RFC'ed patch for server push
support.

You emailed me directly about the aforementioned patch so I'll just respond
here as it's relevant:

The patch should hit in 7.1 but it has been requested that tests be added =
=E2=80=94
and we can't add tests with a server push supporting HTTP/2 server against
which to push.

I'm working with Pierre Joye (CC'ed) to try and update the cli-server to
use libnghttp2 to turn it into a fully fledged HTTP/2 compliant server with
support for server push and things like multiplexing (see:
http://wiki.php.net/rfc/cli_server_http2). Curl also uses libnghttp2 for
it's HTTP/2 support.

I hope to eventually (7.2+) use libnghttp2 to add an ext/nghttp2 HTTP
client and update the HTTP streams layer to support HTTP/2 also.

I'd welcome your collaboration on any of this.

- Davey

On Sat, Apr 23, 2016 at 12:30 PM, Pierrick Charron <pierrick@adoy.net>
wrote:

> Hi internals,
>
> I took some time to add some easy to implement new "features" that were
> implemented in libcurl but missing in ext/curl. Most of them are just
> exposing a new constant in ext/curl and dispatched in the curl_setopt
> function. I created a branch over master but the patch is applicable
> without conflict the 7.0 branch.
>
> https://github.com/php/php-src/compare/master...adoy:curl-update
>
> I was wondering since it's not a big patch and it only introduce new
> constants :
>
> - Should I commit this patch to 7.0 and master or only master
> - Should I do a RFC to include this patch ?
>
> Thanks for your feedback
> Pierrick
>
>
>
>
>
>
>

--e89a8f6427225996d40531301664--