Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92664
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.54 as permitted sender)
MIME-Version: 1.0
Date: Sat, 23 Apr 2016 14:22:04 -0400
Message-ID: <CAOsHV+tGtVyBb9frUP0fNrnQVZmiWivJ2OHsDmZ8q+1N8Xpb1w@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113e9f6666305e05312b06a7
Subject: [PHP-DEV][RFC] Callable Types
From: marcio.web2@gmail.com (Marcio Almada)

--001a113e9f6666305e05312b06a7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Redirecting this to the list as this message was sent privately probably by
accident :)

---------- Forwarded message ----------
From: Mathieu Rochette <mathieu@texthtml.net>
Date: 2016-04-23 12:44 GMT-04:00
Subject: Re: [PHP-DEV][RFC] Callable Types
To: Marcio Almada <marcio.web2@gmail.com>


On 04/22/2016 06:12 AM, Marcio Almada wrote:

Hello everyone,

We just completed the draft for the "Callable Types" RFC. This RFC has been
recently mentioned during other type related threads on this mailing list,
so it feels to be the right time to put the proposal in context:

The proposal is at https://wiki.php.net/rfc/callable-types

It looks very nice overall :) and would be, imho, a great addition to PHP


I have a few comments, first about the optional arguments, the example in
the rfc says :
> // That means that foo() could call $cb and pass anything as a first
argument and if it would be something that is not an instance of A the call
would fail.
I don't get why foo would be declared as

function foo(callable() $cb) { }

instead of

function foo(callable($any) $cb) { }

if foo intends to call $cb with an argument.


what about optional arguments, eg:

class Foo
{
  private $logger;
  public __construct(Logger $logger =3D null) {$this->logger =3D $logger;}
  public doSomething(callable(int $done, int $remaining, Logger =3D null)
$progressCb) {
    // ...
    for($i =3D 0; $i < $n; $i++) {
      // ...
      $progressCb($i, $n - $i, $this->logger);
    }
  }
}

should that be supported ?


and last one, will instanceof supports this new syntax?



thank you

The W.I.P patch is available for testing through http://3v4l.org under the
RFC tab.

We count with your detailed feedback and insights. Let's have a nice,
respectful and
constructive conversation about the RFC and work on possible improvements!

Thanks
Nikita Nefedov
M=C3=A1rcio Almada



--=20
Mathieu Rochette

--001a113e9f6666305e05312b06a7--