Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92632
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain seld.be designates 74.125.82.42 as permitted sender)
To: internals@lists.php.net
References: <BY2PR0201MB178479B3AF8BD49583233034BF6E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <CAESVnVrNqpqsTUCdHiQi8j3d4KVz8ZqRh6pEVJegR-EsmFN3_g@mail.gmail.com>
 <5719D016.10401@zend.com>
Message-ID: <5719E92A.5040606@seld.be>
Date: Fri, 22 Apr 2016 10:04:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <5719D016.10401@zend.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] PHP Attributes
From: j.boggiano@seld.be (Jordi Boggiano)

On 22/04/2016 08:17, Dmitry Stogov wrote:
>
>
> On 04/22/2016 05:15 AM, Sara Golemon wrote:
>> On Thu, Apr 21, 2016 at 2:13 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>>> I would like to present an RFC proposing support for native annotation.
>>>
>> I'm trying to imagine where the benefit of non-constant expressions
>> comes in.
>>
>> <<foo($a < 1)>>
>>
>> Assuming we roll in php-ast at the same time (which is a big addition,
>> IMO, and deserves its own separate RFC), what are users meant to do
>> with this?  Even if there's a use-case here, one could accomplish the
>> same thing with:
>>
>> <<foo('$a < 1')>>
>>
>> And manually running that string into php-ast if that's what the
>> caller wanted.
>
> Good point. It's really not a big deal to run
> ast\parse_code($r->getAttributes()["foo"])
> This would simplify the implementation a bit.

I can't speak for the implementation details, but I see a few benefits 
of having real AST vs a string.. You get syntax highlighting in editors, 
and most importantly compile time syntax errors if you messed up.

Cheers

-- 
Jordi Boggiano
@seldaek - http://seld.be