Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92618
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5719598E.4000006@zend.com>
References: <BY2PR0201MB178479B3AF8BD49583233034BF6E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
	<CAEPJdu=EOiMsVpbU8U2diHguaJshWK1DLnKhq=uAHMbHCvuF-w@mail.gmail.com>
	<5719598E.4000006@zend.com>
Date: Thu, 21 Apr 2016 17:02:26 -0600
Message-ID: <CAObuZdtp361jHQNtHtieCx6mbpufTSmCmsTuAgKS0BGfufzE=A@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134e5da378fdc053106b490
Subject: Re: [PHP-DEV] [RFC] PHP Attributes
From: derokorian@gmail.com (Ryan Pallas)

--001a1134e5da378fdc053106b490
Content-Type: text/plain; charset=UTF-8

On Thu, Apr 21, 2016 at 4:51 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>
>> About expressions, isn't there an ambigoutiy? <<test(1)>> is a "plain"
>> name, value based attribute. But it could also be an ast\node of a function
>> call to "test(1)"
>>
> even in AST scalars are scalars.
> so <<test(1+2)>> would return: ast\node "+" with two children int(1) and
> int(2).
>
> I am wondering if they shouldn't get their own start/end signs to clear
>> that up, <<<test(1)>> vs <<test(1)>>.
>>
>
> no need for extra complication.
>
> Since the encapsulated meta-data is an AST, and as you say any valid php
expression will be valid here, what about bit shifting?

<<Test(FOO >> BAR)>>

Are there concerns about finding the T_SR token, which is also the end
annotation symbol? I've not done any work in the parser, so excuse me if
that is an insanely stupid question :)

Otherwise, I think this RFC looks great, and appreciate your work on this :)

Ryan

--001a1134e5da378fdc053106b490--