Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:9261 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42683 invoked by uid 1010); 16 Apr 2004 15:38:49 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 42629 invoked from network); 16 Apr 2004 15:38:49 -0000 Received: from unknown (HELO mirapoint.kettering.edu) (192.138.137.82) by pb1.pair.com with SMTP; 16 Apr 2004 15:38:49 -0000 Received: from coogle.localdomain (pcp09031773pcs.mtmors01.mi.comcast.net [68.61.83.224]) by mirapoint.kettering.edu (MOS 3.4.5-GR) with ESMTP id ANE04422 (AUTH via LOGINBEFORESMTP); Fri, 16 Apr 2004 11:38:47 -0400 (EDT) Reply-To: john@coggeshall.org To: Derick Rethans Cc: Nuno Lopes , PHP Internals In-Reply-To: References: <00cc01c422e1$46a4adc0$0100a8c0@pc07653> <1082070778.17792.18.camel@coogle.localdomain> Content-Type: text/plain Message-ID: <1082130174.31819.51.camel@coogle.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Fri, 16 Apr 2004 11:42:54 -0400 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Exceptions and a real example: Tidy From: john@coggeshall.org (John Coggeshall) On Fri, 2004-04-16 at 03:32, Derick Rethans wrote: > Do you mean E_ERRORS become exceptions or also E_WARNINGS? E_WARNINGS > should never become exceptions as it's a non-fatal error. E_WARNINGs are exceptions. If you look at the code with the patch applied, I've downgraded all truly minor error conditions to E_NOTICE and made E_WARNINGs errors which are actually problems (i.e. I couldn't find this file), but recoverable. Alan pointed out that it'd be nice if exceptions didn't necessary stop the script if it wasn't caught -- but considering that isn't available at this time this is the best solution. In 5.1, if we have exceptions which are not terminating if uncaught, I'll upgrade a few of the thrown exceptions in Tidy to them. I'll commit my changes later today with the suggestions made by Ilia and others barring any strong arguments against the solution. John -- -=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=- John Coggeshall http://www.coggeshall.org/ The PHP Developer's Handbook http://www.php-handbook.com/ -=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=-