Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92573
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5717E02C.9030505@gmail.com>
References: <5717D70E.5010706@lsces.co.uk> <CAFp73XvfuRJG-ncJXcB0cApBiM72F-Mi+kAxm7A=bvCuo2NnTA@mail.gmail.com>
 <5717E02C.9030505@gmail.com>
Date: Wed, 20 Apr 2016 16:07:56 -0400
Message-ID: <CAFp73XtSE8KP5h90_yf_nG=K0heEnyywDi-YZ01S8GC9g3SNTg@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113fd4026f90d70530f02776
Subject: Re: [PHP-DEV] Quick sanity check ...
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

--001a113fd4026f90d70530f02776
Content-Type: text/plain; charset=UTF-8

The question here is how type strictness would benefit the language.
I agree with you on most parts. But still... if the class was declared like
this:

class CancelOutdatedOrdersDTO {
    public int $olderThan;
}

Wouldn't that be solved entirely? Code would crash (through a TypeError),
it would never be pushed to production and we would never have experienced
this problem.


PS: I just gave one example... we didn't actually loose 100k, but I had to
spend an hour manually addressing the sales back to pending status.

Regards,

On Wed, Apr 20, 2016 at 4:01 PM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> Hi!
>
> > The outcome is easy to grasp. Because it did not crash by a TypeError
> > (which would also require the file to be declared as strict), and we lost
> > 100k in sales. But PHP does not need more strictness...
>
> In other words, somebody wrote code that is supposed to only accept ints
> but does no checks. Somebody wrote tests that actually don't test
> anything. Somebody signed off on code that was not properly designed or
> tested to go into production. And the language is to blame. Right.
>
> --
> Stas Malyshev
> smalyshev@gmail.com
>



-- 
Guilherme Blanco
Lead Architect at E-Block

--001a113fd4026f90d70530f02776--