Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92550
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADxrgCO7F0-suQDbLmnU_ouB=m4cTm8MK=PiGc0XTpjtP2deiQ@mail.gmail.com>
References: <CADxrgCO7F0-suQDbLmnU_ouB=m4cTm8MK=PiGc0XTpjtP2deiQ@mail.gmail.com>
Date: Wed, 20 Apr 2016 17:17:39 +0200
Message-ID: <CAF+90c98k7A0p7ESKfvZw_9x7c-EkT-6Cx96FFpJFFFuWzx0NQ@mail.gmail.com>
To: Adam Baratz <adam.baratz@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113f43dc2755a40530ec181f
Subject: Re: [PHP-DEV] writing .phpt tests against IS_INDIRECT values
From: nikita.ppv@gmail.com (Nikita Popov)

--001a113f43dc2755a40530ec181f
Content-Type: text/plain; charset=UTF-8

On Wed, Apr 20, 2016 at 5:08 PM, Adam Baratz <adam.baratz@gmail.com> wrote:

> I'm contributing to an extension --
> https://github.com/jbboehr/php-mustache
> -- and part of that has been little fixes for PHP7. I posted a PR to fix
> how it was handling zvals that came in as IS_INDIRECT. The maintainer asked
> if I could extend the .phpt coverage accordingly. The reading I've done has
> made it sound like this is an implementation detail that would never
> surface in userland. Is that true, or is there something I can do from
> tests to make sure these code paths get used?
>

Assuming you're talking about hashtables here and not engine code, there
are two places where INDIRECT values are used:
a) The object properties hashtable (if used) contains INDIRECT references
to declared properties in the property table.
b) The $GLOBALS array contains INDIRECT references to variables in the CV
table.

That's the only two cases how you should be able to encounter INDIRECTs in
"normal" extension code. (I think.)

Nikita

--001a113f43dc2755a40530ec181f--