Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:92547 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 53425 invoked from network); 20 Apr 2016 15:08:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Apr 2016 15:08:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=adam.baratz@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=adam.baratz@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.182 as permitted sender) X-PHP-List-Original-Sender: adam.baratz@gmail.com X-Host-Fingerprint: 209.85.213.182 mail-ig0-f182.google.com Received: from [209.85.213.182] ([209.85.213.182:36645] helo=mail-ig0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F2/7C-14036-85B97175 for ; Wed, 20 Apr 2016 11:08:08 -0400 Received: by mail-ig0-f182.google.com with SMTP id f1so130888201igr.1 for ; Wed, 20 Apr 2016 08:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=0BmDy1tTWDWKor2r5on+bWhJJcM1v7QJNh5wo77RzOc=; b=Q9aKdMe2Rc4Di7oSyCfErdgupkR23gmD95Rrz4MNalIik61PvjVvpcjKi5eQ+PtTy0 w2D8HpHo7QxfJo7Xuk7BXtsChEPPTESOWy1Ibfb4fvwu34mEfMfhGZcEiQI+fNy0BPpH y/L8H+yaWzsATdaNSDNX4L5wctR7PCrE/TA5gNovg6VT+9RTdlCTT17n26+IK3ai2UWP g0M4velSwjrepLPJ2IOrQOlw6KDlMyNsqvPAVLvuZxvkFlShpFNF/NKsVRATtRkR2kIT wkwDL1aGEdEXANEuyI9Vt7ksRbhQThilZlCP6ABpC8Fiv4yBwj/O/E4ozGyAKEAC2lP7 gmGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=0BmDy1tTWDWKor2r5on+bWhJJcM1v7QJNh5wo77RzOc=; b=S5mULDQ1cenqxRpJ39dTKMqK+lsKnhJ/9Sp/8BUWDUYfc0mbe67J6J0d2butqH+/W6 bAA1CBkX/1hPRrSNlquBnzGTYot5YnSIT5WX2BIceYtVBZ6FW+VNdNGnJrOh2xfOi3WO 9Mz8G7oNyTmSe7yPNNvwNGIYFBYv9qMZ1SkDMCr+dmwmgnW3GxzFmt4167WeNyQ6HNBy EamAeqi8iB9HSWgxFYTwfH5XSzAfZ6+oEH1SPljClFPRDo04fIbJI63eXwgoait1cKT3 hHoLjqxKbjPa/oxbJimtRfArZhAgpwLRaYbaYlUq3NgrmvMeryheQudmYpJOt/wHaf8T nE/w== X-Gm-Message-State: AOPr4FWMOTYms59jWdRaRuSALOFkRqarB7RdBiEqizeCp7H26Wd9ypCfzPryLTT/DYgO4Hn272bcR5RXBVT6XQ== MIME-Version: 1.0 X-Received: by 10.50.8.97 with SMTP id q1mr4299913iga.26.1461164885331; Wed, 20 Apr 2016 08:08:05 -0700 (PDT) Received: by 10.64.26.131 with HTTP; Wed, 20 Apr 2016 08:08:05 -0700 (PDT) Date: Wed, 20 Apr 2016 11:08:05 -0400 Message-ID: To: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e013d09a8f2f5d90530ebf55d Subject: writing .phpt tests against IS_INDIRECT values From: adam.baratz@gmail.com (Adam Baratz) --089e013d09a8f2f5d90530ebf55d Content-Type: text/plain; charset=UTF-8 I'm contributing to an extension -- https://github.com/jbboehr/php-mustache -- and part of that has been little fixes for PHP7. I posted a PR to fix how it was handling zvals that came in as IS_INDIRECT. The maintainer asked if I could extend the .phpt coverage accordingly. The reading I've done has made it sound like this is an implementation detail that would never surface in userland. Is that true, or is there something I can do from tests to make sure these code paths get used? Thanks, Adam --089e013d09a8f2f5d90530ebf55d--