Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92480
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.180 as permitted sender)
To: bishop@php.net
References: <CADFyporyFgnMgetcEj8FZUFs1Lbc_VidBsxg5jBE7J4_OFzKTQ@mail.gmail.com>
 <CA+kxMuTFfqHZa4sXNv=Cfcm8w6eHdkKSGYiPdUiTJ1DGd6_VQQ@mail.gmail.com>
 <CADyq6sJP_BYEmmTWzJ4OvhcM9uto2EY+vefZTKovAaKBA8hs7w@mail.gmail.com>
 <CAEYWF=6+t_Td5Gb4grOdkDogFZaEOxKs7FYonK9OsOuuybOncQ@mail.gmail.com>
 <571581C7.7010901@gmail.com>
 <CAEYWF=4fTeYn9oDr_x+i6G2=boyspX07d8S2SH1A-ZdBqP_ZMA@mail.gmail.com>
 <571589AF.3090502@gmail.com>
 <CAEYWF=48DmTT8t6TL1n2euosE1cozVs==bfCsbHsN4WiGPvgig@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <5716755E.1040807@gmail.com>
Date: Tue, 19 Apr 2016 11:13:50 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <CAEYWF=48DmTT8t6TL1n2euosE1cozVs==bfCsbHsN4WiGPvgig@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [VOTE] Catching Multiple Exception Types
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> namespace Application;
> function log(Eloquent\Collection | Haldayne\Map $entity) {
>     $logger->log($entity->toArray());
> }

This is bad design. It assumes that two completely unrelated classes
have the same function and it means the same. If it's indeed true, we
have a way to express it. It's called "interface". If it's not true, and
you are just duck-typing, you should not pretend you use strict types,
and drop types completely. You shouldn't try yo sit on both chairs at
the same time and pretend you're using strict typing while in fact
duck-typing.

> "Ugh, this is much easier in multi-catch. If only functions took
> multiple types, this would be much simpler to write."

And it would be completely wrong, abuse of typing. If you mean to say
"anything that has log method", you should either have interface or just
get rid of the strictness and duck-type it and rely on PHP to throw
exception if anything happens. Otherwise it is just a sloppy design.

-- 
Stas Malyshev
smalyshev@gmail.com