Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92462
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAL=_i_==wsq5j2Jf1QdusxaCBU8COX3eJvZY+puD8zH1zCrTXw@mail.gmail.com>
References: <CAL=_i_==wsq5j2Jf1QdusxaCBU8COX3eJvZY+puD8zH1zCrTXw@mail.gmail.com>
Date: Tue, 19 Apr 2016 16:18:47 +0200
Message-ID: <CAF+90c_3Sj7zqJaQy6u=3RQOxh+Y7uZ7Eo-pW2m=Ty95npfjfA@mail.gmail.com>
To: Joe Watkins <pthreads@pthreads.org>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114891c6cb09e80530d72726
Subject: Re: [PHP-DEV] RFC: Anonymous Class Lexical Scope
From: nikita.ppv@gmail.com (Nikita Popov)

--001a114891c6cb09e80530d72726
Content-Type: text/plain; charset=UTF-8

On Tue, Apr 19, 2016 at 3:31 PM, Joe Watkins <pthreads@pthreads.org> wrote:

> Morning Internals,
>
>     Please review the following RFC:
>
>     https://wiki.php.net/rfc/lexical-anon
>
>     A look at the patch from those of you that do that would be good :)
>

Hey Joe,

The syntax and semantics proposed in this RFC don't sit quite well with me.
Especially the fact that a use($foo) on the class is then used as
$this->foo in methods is non-intuitive to me, as it differs from how the
same syntax behaves on closures. I'd like to suggest an alternative syntax:

$foo = 42;
return new class {
    private $bar = $foo;
    public function getBar() { return $this->bar; }
}

That is, allow properties inside the anonymous class to be initialized
based on values from the surrounding scope. This is more explicit (clearly
shows that a property is being created), it allows explicit control over
the visibility and, depending on implementation, might be more flexible
with regards to the values it accepts. It probably doesn't make sense to
restrict this to specific expressions, so all of

return new class {
    private $a = $var;
    private $b = $obj->prop;
    private $d = $obj->prop ?? 'default';
    // ...
}

could be fine.

Thanks,
Nikita

--001a114891c6cb09e80530d72726--