Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:9245
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
In-Reply-To: <1082070778.17792.18.camel@coogle.localdomain>
References: <00cc01c422e1$46a4adc0$0100a8c0@pc07653> <1082070778.17792.18.camel@coogle.localdomain>
Mime-Version: 1.0 (Apple Message framework v613)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-ID: <07508FE8-8F3A-11D8-B08C-000A95E073A0@php.net>
Content-Transfer-Encoding: 7bit
Cc: Nuno Lopes <nlopess@php.net>,
	PHP Internals <internals@lists.php.net>
Date: Thu, 15 Apr 2004 17:07:20 -0700
To: john@coggeshall.org
Subject: Re: [PHP-DEV] Exceptions and a real example: Tidy
From: sterling@php.net (Sterling Hughes)


On Apr 15, 2004, at 4:12 PM, John Coggeshall wrote:

> Attached is a patch which I hope will keep people happy when it comes 
> to
> specifically the Tidy extension. I'd like some feedback on this before 
> I
> commit it / throw it away:
>
> Changes:
>
>   - All errors were re-evaluated, and those (such as a bogus config
>     option) were demoted to E_NOTICE or promoted to E_ERROR as
>     necessary
>   - Those errors which are truly E_WARNING will behave as such when
>     called from a procedural context. If called from an object oriented
>     context, they will be represented as exceptions.
>
> I also looked at the bugs you reported, Nuno but I couldn't reproduce
> some of them. In either case, the ones i could reproduced should be
> fixed.
>


-			TIDY_THROW("Could not retrieve key from option array");
+			zend_error(E_ERROR, "Could not retrieve key from option array");

Also wrong.  You never through an E_ERROR for this sort of thing.

-sterling