Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92242
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.47 as permitted sender)
To: Sara Golemon <pollita@php.net>
References: <CAESVnVo-BV7BOWV2H4ie1z48XofKnejArHm++zB9wGRPC4rB6w@mail.gmail.com>
 <570C2EB8.4080009@gmail.com>
 <CAESVnVqvmND+6UwjjKyJW2W+ftfxemeq7VSQ6SpLv0gq_m=yHg@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <570DC9D7.4090000@gmail.com>
Date: Tue, 12 Apr 2016 21:23:51 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <CAESVnVqvmND+6UwjjKyJW2W+ftfxemeq7VSQ6SpLv0gq_m=yHg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] IntlCharsetDetector
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> That said, how do you feel about compromising by adding this function
> in addition to the raw API?
> 
> function ucsdet_detect_encoding(string $text, string $hint = null,
> bool $filter = false) {
>   $det = new IntlCharsetDetector($text);
>   if ($hint !== null) {
>     $det->setDeclaredEncoding($hint);
>   }
>   $det->enableInputFiltering($filter);
>   return $det->detect()['name'];
> }

That works too, but object one has its uses - e.g. preparing one
detector and detecting multiple texts, like library, etc. Of course, one
can do setText, but it's extra hop that doesn't seem to add anything.

I'd take both :)
-- 
Stas Malyshev
smalyshev@gmail.com