Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92208
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.215.50 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <570C2EB8.4080009@gmail.com>
References: <CAESVnVo-BV7BOWV2H4ie1z48XofKnejArHm++zB9wGRPC4rB6w@mail.gmail.com>
	<570C2EB8.4080009@gmail.com>
Date: Mon, 11 Apr 2016 16:25:25 -0700
Message-ID: <CAESVnVqvmND+6UwjjKyJW2W+ftfxemeq7VSQ6SpLv0gq_m=yHg@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] IntlCharsetDetector
From: pollita@php.net (Sara Golemon)

On Mon, Apr 11, 2016 at 4:09 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
> The API looks a bit strange - new IntlCharsetDetector($text) and then
> detect(). Can't we just have detect([$text])?
>
I went with a direct wrapping of the underlying API because it always
feels like we regret adding magic eventually.  It's trivial for some
composer installable library to wrap this into something nicer.  In
fact, one probably WOULD use a userspace library in order to provide
fallback to mb_detect_encoding() on PHP < 7.1

That said, how do you feel about compromising by adding this function
in addition to the raw API?

function ucsdet_detect_encoding(string $text, string $hint = null,
bool $filter = false) {
  $det = new IntlCharsetDetector($text);
  if ($hint !== null) {
    $det->setDeclaredEncoding($hint);
  }
  $det->enableInputFiltering($filter);
  return $det->detect()['name'];
}

That'll give simplicity for the 80% case (I have a string, I want a
best guess) but still provide the true API for consideration of
confidence and/or other guesses.

-Sara