Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92178
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.66 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPhkiZxHaV=FarwuR2YQSeDB1-zXLgGd_KFNYXa1CGv1rO8WCw@mail.gmail.com>
References: <CAGa2bXb-jON8qZyje_ETckyO-KCmcbhTjcJt=NJZ1agAgzqMoQ@mail.gmail.com>
 <CAPhkiZx7zc1=1zyx=vJvZtr7x7OhktDFCHMK4GdOCD_DSqbKCg@mail.gmail.com>
 <CAGa2bXaZnsGnrKAAPmxHG+hut3+1=8bdOER--WrsXXowoiXu=A@mail.gmail.com>
 <CAGa2bXbcfsN6+CSB85_1Utm-d8s-KC2ZVtnxmJrTHK3RTKc2Ng@mail.gmail.com>
 <CAPhkiZx-R1f8=nBTkVQMxKyVbU3zx_-c2n6ao8mDOMKdTZjeJQ@mail.gmail.com>
 <CAGa2bXbjseLnj5jwO-erizp-Q9atg3r4c8K7a+CFFtv+SZ8==w@mail.gmail.com>
 <CAPhkiZw434DP2ZHRrnFORibg0eCdq71xjESbhXhJPUn4M-GX+Q@mail.gmail.com>
 <CAGa2bXa+D9AXxNqr7LbBoidXzpPt5usU53_a3mJPHOAX34iUKw@mail.gmail.com> <CAPhkiZxHaV=FarwuR2YQSeDB1-zXLgGd_KFNYXa1CGv1rO8WCw@mail.gmail.com>
Date: Sat, 9 Apr 2016 08:24:13 +0900
Message-ID: <CAGa2bXa0ENOHsOYp_OWO4e031TrWaxEiW1ya5Bqq6Ag2SWnAdg@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC][Discussion] Add session_gc()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Andrey,

On Fri, Apr 8, 2016 at 6:54 PM, Andrey Andreev <narf@devilix.net> wrote:
> On Fri, Apr 8, 2016 at 12:29 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>>
>> Hi Andrey,
>>
>> On Fri, Apr 8, 2016 at 6:20 PM, Andrey Andreev <narf@devilix.net> wrote:
>> > On Fri, Apr 8, 2016 at 11:33 AM, Yasuo Ohgaki <yohgaki@ohgaki.net>
>> > wrote:
>> >>
>> >> Hi Andrey,
>> >>
>> >> On Fri, Apr 8, 2016 at 4:57 PM, Andrey Andreev <narf@devilix.net>
>> >> wrote:
>> >> >>
>> >> >> PS(gc_maxlifetime) is needed, so I fixed the last commit.
>> >> >>
>> >> >
>> >> > It is necessary for probability-triggered GC because you don't have
>> >> > another
>> >> > way of giving a TTL value then, but that's not the case for a direct
>> >> > session_gc() call.
>> >>
>> >> PS(gc_maxlifetime) is not related directly to probability based GC,
>> >> but it's about which session should be deleted.
>> >>
>> >> Save handlers are supposed to delete inactive sessions exceeds
>> >> PS(gc_maxlifetime) when GC is issued. Save handlers are not suppose to
>> >> use PS(vars) directly and should use passed TTL parameter. Therefore,
>> >> the parameter is passed.
>> >>
>> >
>> > It is not directly related to gc_probability it is very obviously the
>> > result
>> > gc_probability-based design.
>> >
>> > Still, even if we agree to disagree on that, it's not a blocker for
>> > maxlifetime being overridable via a parameter.
>>
>> We need TTL value and the TTL is gc_maxlifetime.
>> How would you specify session data to be removed?
>>
>> TTL value is mandatory.
>
>
>
> I wrote this pseudo-code in my very first reply to this thread ...
>
>     function session_gc($ttl = ini_get('session.gc_maxlifetime')) {}
>
> If that's unclear, here's a more verbose way to put it:
>
>     function session_gc($ttl = null)
>     {
>         if (empty($ttl))
>         {
>             $ttl = ini_get('session.gc_maxlifetime');
>         }
>
>         // ...
>     }
>
> It just gives the ability to override the INI value for those who don't want
> or need it.

I thought you claim that use of gc_maxlifetime is wrong.

3. If session_gc() bypasses the gc_probability, gc_divisor INI
settings*, then why does it still rely on gc_maxlifetime?

Anyway, you're suggesting session_gc() should have $ttl =
ini_get('session.gc_maxlifetime') as the TTL parameter. This sounds
reasonable and I'll add optional 1st parameter.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net