Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92169
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXa+D9AXxNqr7LbBoidXzpPt5usU53_a3mJPHOAX34iUKw@mail.gmail.com>
References: <CAGa2bXb-jON8qZyje_ETckyO-KCmcbhTjcJt=NJZ1agAgzqMoQ@mail.gmail.com>
	<CAPhkiZx7zc1=1zyx=vJvZtr7x7OhktDFCHMK4GdOCD_DSqbKCg@mail.gmail.com>
	<CAGa2bXaZnsGnrKAAPmxHG+hut3+1=8bdOER--WrsXXowoiXu=A@mail.gmail.com>
	<CAGa2bXbcfsN6+CSB85_1Utm-d8s-KC2ZVtnxmJrTHK3RTKc2Ng@mail.gmail.com>
	<CAPhkiZx-R1f8=nBTkVQMxKyVbU3zx_-c2n6ao8mDOMKdTZjeJQ@mail.gmail.com>
	<CAGa2bXbjseLnj5jwO-erizp-Q9atg3r4c8K7a+CFFtv+SZ8==w@mail.gmail.com>
	<CAPhkiZw434DP2ZHRrnFORibg0eCdq71xjESbhXhJPUn4M-GX+Q@mail.gmail.com>
	<CAGa2bXa+D9AXxNqr7LbBoidXzpPt5usU53_a3mJPHOAX34iUKw@mail.gmail.com>
Date: Fri, 8 Apr 2016 12:54:05 +0300
Message-ID: <CAPhkiZxHaV=FarwuR2YQSeDB1-zXLgGd_KFNYXa1CGv1rO8WCw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113dd96ae38bf0052ff62cea
Subject: Re: [PHP-DEV] [RFC][Discussion] Add session_gc()
From: narf@devilix.net (Andrey Andreev)

--001a113dd96ae38bf0052ff62cea
Content-Type: text/plain; charset=UTF-8

Hi,

On Fri, Apr 8, 2016 at 12:29 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Andrey,
>
> On Fri, Apr 8, 2016 at 6:20 PM, Andrey Andreev <narf@devilix.net> wrote:
> > On Fri, Apr 8, 2016 at 11:33 AM, Yasuo Ohgaki <yohgaki@ohgaki.net>
> wrote:
> >>
> >> Hi Andrey,
> >>
> >> On Fri, Apr 8, 2016 at 4:57 PM, Andrey Andreev <narf@devilix.net>
> wrote:
> >> >>
> >> >> PS(gc_maxlifetime) is needed, so I fixed the last commit.
> >> >>
> >> >
> >> > It is necessary for probability-triggered GC because you don't have
> >> > another
> >> > way of giving a TTL value then, but that's not the case for a direct
> >> > session_gc() call.
> >>
> >> PS(gc_maxlifetime) is not related directly to probability based GC,
> >> but it's about which session should be deleted.
> >>
> >> Save handlers are supposed to delete inactive sessions exceeds
> >> PS(gc_maxlifetime) when GC is issued. Save handlers are not suppose to
> >> use PS(vars) directly and should use passed TTL parameter. Therefore,
> >> the parameter is passed.
> >>
> >
> > It is not directly related to gc_probability it is very obviously the
> result
> > gc_probability-based design.
> >
> > Still, even if we agree to disagree on that, it's not a blocker for
> > maxlifetime being overridable via a parameter.
>
> We need TTL value and the TTL is gc_maxlifetime.
> How would you specify session data to be removed?
>
> TTL value is mandatory.
>


I wrote this pseudo-code in my very first reply to this thread ...

    function session_gc($ttl = ini_get('session.gc_maxlifetime')) {}

If that's unclear, here's a more verbose way to put it:

    function session_gc($ttl = null)
    {
        if (empty($ttl))
        {
            $ttl = ini_get('session.gc_maxlifetime');
        }

        // ...
    }

It just gives the ability to override the INI value for those who don't
want or need it.

Cheers,
Andrey.

--001a113dd96ae38bf0052ff62cea--