Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:92167 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17157 invoked from network); 8 Apr 2016 09:30:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Apr 2016 09:30:25 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.68 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.213.68 mail-vk0-f68.google.com Received: from [209.85.213.68] ([209.85.213.68:34399] helo=mail-vk0-f68.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 60/C4-25122-F2A77075 for ; Fri, 08 Apr 2016 05:30:23 -0400 Received: by mail-vk0-f68.google.com with SMTP id a6so5032548vkh.1 for ; Fri, 08 Apr 2016 02:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+onWJcYGuuCfZb99f9y+GAiLdVEs3si7Pfn1B0eEl20=; b=hg9ptM7bmvMzGs0yRL9wiMDUrdhp1n5rgwbFG6XVhHjQsOPtx20v3peAY+gRSYtgvP 1mhvKEXay0JD6FsDJpZDY2CBd6jDBBBZdwJSOfqEuBZKA7VCxnH9hUuRlfQC3/xpewbW FeJiH/zL+G1HczoznzEEvboBpX/5pfwX27TNElfdKb3ZxSelHMbU5OS6BvT8TqyJnu4d O0BkS9JcLgi/xTFrko510heEnud3hzpX4EcCmGGRkonJ9WapuW75Vlr6jIKrE/SOU4is IzuyWbK1hRy3wiNkLONP6UZRABDZmNSBwu7Moyg60txLm4DcNj6hAkVH1VXu8l7GfrU6 52Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+onWJcYGuuCfZb99f9y+GAiLdVEs3si7Pfn1B0eEl20=; b=UGDfPKMDSP45aNyTkXo6FQqbYpwMhwXitGpOAEFY40mhMy8y+5Rb/vxsHQuwamrTZq 4shiqi000imNevgWrXYPw0HhBwgZ4g0AUCNt/x3wNHw5umHnXuRSlQr8UEXLjB0heJ4C +9kpqygq94w/VQAZW62rViE4cmKdZ8eSVigsA+qCBg0uTAdbigDOvj8TGhu35jTjjPqn TDsQK/Gl07N/g7dgftei8/4u7QuJbcSVHZHbs6EANKWUL/VQ1tGaRvKnll7CCKC/L+vr kOLX7oBiYVCGLkNIurLaLuseKgNfKKgv5AWOysMmxEMjrhQf0TSAv4qplmk13isIgnV1 9gPw== X-Gm-Message-State: AD7BkJIkDwmoRhF0Zuk3N+5FM20+qNUfBHe147qutC+6A0JyLejlXr519J0Il1xzhCBrir5nr8/aKFpmmkJ7nA== X-Received: by 10.176.5.162 with SMTP id e31mr3194777uae.126.1460107820529; Fri, 08 Apr 2016 02:30:20 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.159.40.7 with HTTP; Fri, 8 Apr 2016 02:29:40 -0700 (PDT) In-Reply-To: References: Date: Fri, 8 Apr 2016 18:29:40 +0900 X-Google-Sender-Auth: EEkOQLRWVd42xrRrKUypD_zU-14 Message-ID: To: Andrey Andreev Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][Discussion] Add session_gc() From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Andrey, On Fri, Apr 8, 2016 at 6:20 PM, Andrey Andreev wrote: > On Fri, Apr 8, 2016 at 11:33 AM, Yasuo Ohgaki wrote: >> >> Hi Andrey, >> >> On Fri, Apr 8, 2016 at 4:57 PM, Andrey Andreev wrote: >> >> >> >> PS(gc_maxlifetime) is needed, so I fixed the last commit. >> >> >> > >> > It is necessary for probability-triggered GC because you don't have >> > another >> > way of giving a TTL value then, but that's not the case for a direct >> > session_gc() call. >> >> PS(gc_maxlifetime) is not related directly to probability based GC, >> but it's about which session should be deleted. >> >> Save handlers are supposed to delete inactive sessions exceeds >> PS(gc_maxlifetime) when GC is issued. Save handlers are not suppose to >> use PS(vars) directly and should use passed TTL parameter. Therefore, >> the parameter is passed. >> > > It is not directly related to gc_probability it is very obviously the result > gc_probability-based design. > > Still, even if we agree to disagree on that, it's not a blocker for > maxlifetime being overridable via a parameter. We need TTL value and the TTL is gc_maxlifetime. How would you specify session data to be removed? TTL value is mandatory. -- Yasuo Ohgaki yohgaki@ohgaki.net