Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:92165 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14092 invoked from network); 8 Apr 2016 09:20:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Apr 2016 09:20:19 -0000 Authentication-Results: pb1.pair.com header.from=narf@devilix.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=narf@devilix.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.43 as permitted sender) X-PHP-List-Original-Sender: narf@devilix.net X-Host-Fingerprint: 209.85.218.43 mail-oi0-f43.google.com Received: from [209.85.218.43] ([209.85.218.43:34918] helo=mail-oi0-f43.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 81/14-25122-2D777075 for ; Fri, 08 Apr 2016 05:20:19 -0400 Received: by mail-oi0-f43.google.com with SMTP id p188so129800397oih.2 for ; Fri, 08 Apr 2016 02:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devilix.net; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=JFSir5IJyK+0/fVjQh/5mKpoWpx23tdu2J7eK5IHV34=; b=POh9195EDt98dHwzJ9aQ2dZf4BZFUkIBBFcVPr0p9vsGhOl9qgi6ZBL6g57v7Oi8Lu Tu/UX6iPAY15AW8R/NbU304hYq8Bupzjhoo5WhvaGnmHMaXiBeCy0Q+KTPdfFh3ZvvY1 lgpyB4olPQoBN8V49Ue+w0tMf8tFEqej6+uWE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=JFSir5IJyK+0/fVjQh/5mKpoWpx23tdu2J7eK5IHV34=; b=L5u0VfMwOTeaarN9fn+QTXOZxrEsWCmnEZHzw/xTKz4H4/JYoiETvltx4KIBV8Ev6V aUsGf0cvLIGC523gHf7BQdl9BmU1FwpE8uhr0GjNBxuMSq1CJ1lR/S30hB/Q/JrxHmB9 /xVyhYU0kJdoNS6FGOMRNVvZG9EfD8lN0J6bVi4jt71jzzS//MCXcdbV/iaDscvWP5qc 4Ts43ns7RQNTIgAk38qxJexeNXHU9iDWn1QWKf+GobrQlNuIichv4AJw1v124kXLfapV t03fWz9naUKy4KZqO4KPOmFGwG2wwkVVudrcwaeqxafFtWE9iaYProxQvF9+oCPnim5A u4lg== X-Gm-Message-State: AD7BkJLrhtFPyTUE46/ekqTcu+3o8GFxv1BNqQSWfNy5Ngc7QlmIBedheoUgNaijf+2fmFVc8iFtKOmWKx6x4Q== MIME-Version: 1.0 X-Received: by 10.202.69.8 with SMTP id s8mr3756637oia.42.1460107216438; Fri, 08 Apr 2016 02:20:16 -0700 (PDT) Received: by 10.202.175.87 with HTTP; Fri, 8 Apr 2016 02:20:16 -0700 (PDT) In-Reply-To: References: Date: Fri, 8 Apr 2016 12:20:16 +0300 Message-ID: To: Yasuo Ohgaki Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a113dd96af86662052ff5b3f5 Subject: Re: [PHP-DEV] [RFC][Discussion] Add session_gc() From: narf@devilix.net (Andrey Andreev) --001a113dd96af86662052ff5b3f5 Content-Type: text/plain; charset=UTF-8 Hi, On Fri, Apr 8, 2016 at 11:33 AM, Yasuo Ohgaki wrote: > Hi Andrey, > > On Fri, Apr 8, 2016 at 4:57 PM, Andrey Andreev wrote: > >> > >> PS(gc_maxlifetime) is needed, so I fixed the last commit. > >> > > > > It is necessary for probability-triggered GC because you don't have > another > > way of giving a TTL value then, but that's not the case for a direct > > session_gc() call. > > PS(gc_maxlifetime) is not related directly to probability based GC, > but it's about which session should be deleted. > > Save handlers are supposed to delete inactive sessions exceeds > PS(gc_maxlifetime) when GC is issued. Save handlers are not suppose to > use PS(vars) directly and should use passed TTL parameter. Therefore, > the parameter is passed. > > It is not directly related to gc_probability it is very obviously the result gc_probability-based design. Still, even if we agree to disagree on that, it's not a blocker for maxlifetime being overridable via a parameter. Cheers, Andrey. --001a113dd96af86662052ff5b3f5--