Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:92161 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6592 invoked from network); 8 Apr 2016 08:34:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Apr 2016 08:34:05 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.66 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.213.66 mail-vk0-f66.google.com Received: from [209.85.213.66] ([209.85.213.66:36045] helo=mail-vk0-f66.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 10/92-25122-CFC67075 for ; Fri, 08 Apr 2016 04:34:04 -0400 Received: by mail-vk0-f66.google.com with SMTP id x190so15333050vka.3 for ; Fri, 08 Apr 2016 01:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0+WhvmDrc5fGnpTovmVxDjXfLOiWEjMjwFHbL2I9aEQ=; b=F6Ij/Zpl12AOWl8TNzfNLn9vkT71i6lVAksmv2oxZRuAIPwxpgEl6mKtwbTCFaEi2/ fbI6vj8QhQCs4O5dlGyIbigKr5uHdu1jzXpo3B49oWVx9H/QVsnCqFP+CNo6V5MB9cBq SzniK6KvSfrDVMwC01ia5AvZFy5rv+MC9mR2oyFw7ww22Enua4aQni5UKtmbBj3dMlgO b8knWyK9kBFl4sUZRByoz/YI852oxLR/x992cZcBPj6auwA6Ta+lx6Eo5bmNj73QJYYG DVvhrUUIUKJzcLo8OpUbdOUHjY/uSi3NkoEoreXaEKirCvzrhEyAcrIPL3AhCm4ihtyj KL9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0+WhvmDrc5fGnpTovmVxDjXfLOiWEjMjwFHbL2I9aEQ=; b=eymrXd60IwuWDSrpaynxjKZsfocRAog47lKmOD/48b0bKc/1zSZRg0SM/ZY0T0k1hi OghN9A0PZoPW47tLoSnDkq9EYRFjCk1Ar4POcPwSza9jY/GPOpzB/kSOBSemH5aqT7zB kHdk6ESCMzGf+xN0W+nRvZvoDs+Vy2GaJMqlzQhgEMuh9LGQwGpBW0g0KWjBMDY4T369 mfwyV6Wvv7xmiy4K6qqeh022s8X64Vc64rRwNSV+HJ8BLob3CQU3Js0yY62/0RikVPjY Ikl14MYL1BrR6w98GCDaPwT3blQcAFTDp0yyp5YMLb3tZkAnPrhGEoN//2i5tntickDz 3/Zw== X-Gm-Message-State: AD7BkJLuD7CGJFb4dHy7z+19GzRytNknuqHaLe4LdNoiT4nbLzpMMu7E0lryxHEw369f4LTFvXv4mc8bB1D6tQ== X-Received: by 10.159.39.35 with SMTP id a32mr3594705uaa.64.1460104441622; Fri, 08 Apr 2016 01:34:01 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.159.40.7 with HTTP; Fri, 8 Apr 2016 01:33:22 -0700 (PDT) In-Reply-To: References: Date: Fri, 8 Apr 2016 17:33:22 +0900 X-Google-Sender-Auth: -Z7yygoFebkl5co-iCIYovOWTXc Message-ID: To: Andrey Andreev Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][Discussion] Add session_gc() From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Andrey, On Fri, Apr 8, 2016 at 4:57 PM, Andrey Andreev wrote: >> >> PS(gc_maxlifetime) is needed, so I fixed the last commit. >> > > It is necessary for probability-triggered GC because you don't have another > way of giving a TTL value then, but that's not the case for a direct > session_gc() call. PS(gc_maxlifetime) is not related directly to probability based GC, but it's about which session should be deleted. Save handlers are supposed to delete inactive sessions exceeds PS(gc_maxlifetime) when GC is issued. Save handlers are not suppose to use PS(vars) directly and should use passed TTL parameter. Therefore, the parameter is passed. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net