Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92159
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbcfsN6+CSB85_1Utm-d8s-KC2ZVtnxmJrTHK3RTKc2Ng@mail.gmail.com>
References: <CAGa2bXb-jON8qZyje_ETckyO-KCmcbhTjcJt=NJZ1agAgzqMoQ@mail.gmail.com>
	<CAPhkiZx7zc1=1zyx=vJvZtr7x7OhktDFCHMK4GdOCD_DSqbKCg@mail.gmail.com>
	<CAGa2bXaZnsGnrKAAPmxHG+hut3+1=8bdOER--WrsXXowoiXu=A@mail.gmail.com>
	<CAGa2bXbcfsN6+CSB85_1Utm-d8s-KC2ZVtnxmJrTHK3RTKc2Ng@mail.gmail.com>
Date: Fri, 8 Apr 2016 10:57:09 +0300
Message-ID: <CAPhkiZx-R1f8=nBTkVQMxKyVbU3zx_-c2n6ao8mDOMKdTZjeJQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113cf978b45cd5052ff48a80
Subject: Re: [PHP-DEV] [RFC][Discussion] Add session_gc()
From: narf@devilix.net (Andrey Andreev)

--001a113cf978b45cd5052ff48a80
Content-Type: text/plain; charset=UTF-8

Hi,

On Fri, Apr 8, 2016 at 8:12 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Andrey,
>
> On Fri, Apr 8, 2016 at 12:46 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> >>
> >> The signature for SessionHandlerInterface::gc() accepts a TTL value as a
> >> parameter; session_gc() can too:
> >>
> >>     function session_gc($ttl = ini_get('session.gc_maxlifetime')) {}
> >>
> >> * Note: The current patch doesn't actually ignore gc_probability, but I
> >> think that's by mistake (also relevant to my previous point). I'll
> comment
> >> on the PR on GitHub.
> >
> > Good point.
> > Since session module does the job if module should execute GC or not.
> > It should be 1 or very short time.
>

I don't understand what you're saying here. Is it that gc_maxlifetime
should be 1 second? o.O


>
> PS(gc_maxlifetime) is needed, so I fixed the last commit.
>
>
It is necessary for probability-triggered GC because you don't have another
way of giving a TTL value then, but that's not the case for a direct
session_gc() call.

Cheers,
Andrey.

--001a113cf978b45cd5052ff48a80--