Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92156
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.66 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXaZnsGnrKAAPmxHG+hut3+1=8bdOER--WrsXXowoiXu=A@mail.gmail.com>
References: <CAGa2bXb-jON8qZyje_ETckyO-KCmcbhTjcJt=NJZ1agAgzqMoQ@mail.gmail.com>
 <CAPhkiZx7zc1=1zyx=vJvZtr7x7OhktDFCHMK4GdOCD_DSqbKCg@mail.gmail.com> <CAGa2bXaZnsGnrKAAPmxHG+hut3+1=8bdOER--WrsXXowoiXu=A@mail.gmail.com>
Date: Fri, 8 Apr 2016 14:12:43 +0900
Message-ID: <CAGa2bXbcfsN6+CSB85_1Utm-d8s-KC2ZVtnxmJrTHK3RTKc2Ng@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC][Discussion] Add session_gc()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Andrey,

On Fri, Apr 8, 2016 at 12:46 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>>
>> The signature for SessionHandlerInterface::gc() accepts a TTL value as a
>> parameter; session_gc() can too:
>>
>>     function session_gc($ttl = ini_get('session.gc_maxlifetime')) {}
>>
>> * Note: The current patch doesn't actually ignore gc_probability, but I
>> think that's by mistake (also relevant to my previous point). I'll comment
>> on the PR on GitHub.
>
> Good point.
> Since session module does the job if module should execute GC or not.
> It should be 1 or very short time.

PS(gc_maxlifetime) is needed, so I fixed the last commit.

Regards,

P.S. I'm having bad cold. So it may be better not to commit a while :(

--
Yasuo Ohgaki
yohgaki@ohgaki.net