Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92107
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.110.142 as permitted sender)
To: Lin Yo-An <cornelius.howl@gmail.com>
CC: Xinchen Hui <laruence@php.net>, Nikita Popov <nikic@php.net>, Bob Weinand
	<bobwei9@hotmail.com>, Joe Watkins <pthreads@pthreads.org>, internals
	<internals@lists.php.net>
Thread-Topic: Object getter method optimization
Thread-Index: AQHRj0gHiX8X0BnQ5U+SlXD9k2g53598jrHY
Date: Wed, 6 Apr 2016 07:39:06 +0000
Message-ID: <BY2PR0201MB17846D27AD2A265308DF83F5BF9F0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <CAKSD0w7tznoMvvUu2WyYGvNLpw_PoHB_A0UMBKNDPrWJzQsj1g@mail.gmail.com>
In-Reply-To: <CAKSD0w7tznoMvvUu2WyYGvNLpw_PoHB_A0UMBKNDPrWJzQsj1g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR0201MB17846D27AD2A265308DF83F5BF9F0BY2PR0201MB1784_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2016 07:39:06.2074
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1783
Subject: Re: Object getter method optimization
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY2PR0201MB17846D27AD2A265308DF83F5BF9F0BY2PR0201MB1784_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

did you see my patch? It already uses run_time_cache of calling op_array to=
 get getter property offset.


It's also possible to "allocate" slots in "run_time_cache" of caller op_arr=
ay at compile_time, increasing op_array->cache_size. (see zend_compile.c), =
but I don't see a big reason to do it.


Thanks. Dmitry.


________________________________
From: Lin Yo-An <cornelius.howl@gmail.com>
Sent: Tuesday, April 5, 2016 17:32
To: Dmitry Stogov
Cc: Xinchen Hui; Nikita Popov; Bob Weinand; Joe Watkins; internals
Subject: Re: Object getter method optimization

On Tue, Apr 5, 2016 at 10:14 PM, Dmitry Stogov <dmitry@zend.com<mailto:dmit=
ry@zend.com>> wrote:

I think, op_array->type and op_array->fn_flags can't be reused.

Also, usage of op_array->run_time_cache is safer (I remember, I saw some SI=
GSEGV with your patch and opcache.protect_memory=3D1)

Got it.    Does run_time_cache vary when caller is different? maybe I can u=
se the first 2 bytes for the accessor information.

Cheers, Yo-An

--_000_BY2PR0201MB17846D27AD2A265308DF83F5BF9F0BY2PR0201MB1784_--