Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92054
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <56FE7A8F-B093-49AA-BC19-FCB28701855A@zend.com>
References: <CABDNdAHwgx+LJRc_gi9citiypxxWVGFMB+6hrmU+vVYDWCDV_g@mail.gmail.com>
 <56F16023.1010002@gmail.com> <CAPhkiZxYwXKLp8ASkjiwXgzDtjKxJ8rYROCM-t=8sU5=efhg2w@mail.gmail.com>
 <CAPhkiZwOJOkNu4N=h+wQRX4w8-KV=zg9x4khhLRLu199YcqZxw@mail.gmail.com>
 <CABDNdAGh4OjkkEQim6oYK=sZ=zj1Q==HzE=SLJ1E8=a=ku1DqA@mail.gmail.com>
 <CY1PR0201MB17863E4B9D9F53151A900DCDBF870@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CAL=_i_mNwmpg0PWmrm3nTZxn6s33u2QUzavk8w0Fk1OGvbWJtA@mail.gmail.com>
 <CY1PR0201MB1786AAFDC6170AB1585CA7F5BF870@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CY1PR0201MB17867DAC10D401EE9EC49CBCBF870@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CAL=_i_knwzrcXdx1k4ii8YKzrgaREBFcHYGC9ZV_J05ZWVWmzg@mail.gmail.com>
 <56FC4ED6.6050701@telia.com> <CAL=_i_ksOzCV1SUtB2jwSYPm1SL2y3jy43+JSZ3k6KRywsizUg@mail.gmail.com>
 <56FCE6C9.1050302@zend.com> <CAL=_i_kx=94AFi=+iU-+EaqWms_0OfuUHgoOFZQtV1xS98tGWQ@mail.gmail.com>
 <BY2PR02MB298EFF28A29324C3914CA11AC990@BY2PR02MB298.namprd02.prod.outlook.com>
 <56FD4E18.7070703@garfieldtech.com> <CAFp73XtCmqbCC5M6D4rvqYXrFpssh6ga3XNYtCUsE31YJgtaaw@mail.gmail.com>
 <56FE7A8F-B093-49AA-BC19-FCB28701855A@zend.com>
Date: Thu, 31 Mar 2016 14:24:09 -0400
Message-ID: <CAFp73Xuk0Ma5ndvrPDYJqvFQVcxgw9EFrico+pO0woRvwPh12A@mail.gmail.com>
To: Zeev Suraski <zeev@zend.com>
Cc: Larry Garfield <larry@garfieldtech.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113cd5b875b8c7052f5c5f64
Subject: Re: [PHP-DEV] [RFC Discussion] Typed Properties
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

--001a113cd5b875b8c7052f5c5f64
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

My code version is not complete, as the references changed when you include
the optional_type.
It shouldn't be hard to change though... like $$ =3D $3 and also hold $2
somewhere.

On Thu, Mar 31, 2016 at 2:09 PM, Zeev Suraski <zeev@zend.com> wrote:

>
> > On 31 =D7=91=D7=9E=D7=A8=D7=A5 2016, at 20:48, "guilhermeblanco@gmail.c=
om" <
> guilhermeblanco@gmail.com> wrote:
> >
> > To me it's simply as that:
> >
> >
> > class_statement:
> >        variable_modifiers optional_type property_list ';' { $$ =3D $2;
> > $$->attr =3D $1 }
> >    |   ...
> >
> > property_list:
> >        property_list ',' property { $$ =3D zend_ast_list_add($1, $3); }
> >    |   property { $$ =3D zend_ast_create_list(1, ZEND_AST_PROP_DECL, $1=
); }
> > ;
> >
> >
> > I think this makes the concept more palatable compared to others and
> other
> > languages (single type declaration per statement).
> >
>
> Exactly (code version).
>
> >> Honestly I never even realized that you could put multiple declaration=
s
> on
> >> a single line, have never done so, and would reject code from any of m=
y
> >> projects that did so as poor style. :-)  That said, since it is legal =
I
> >> agree that it should be kept unambiguous and consistent.
> >>
> >> From what Zeev is saying, the following seems like a reasonable rule:
> You
> >> get ONE visibility modifier and ONE type statement per declaration, an=
d
> >> both must come at the beginning, period.  That is, the following are
> legal:
> >>
> >> public int $a, $b;
> >> protected $a, $b;
> >> var int $a, $b;
> >>
> >> And always apply across the entire line, period.
> >>
> >> The following are all syntax errors:
> >>
> >> public int $a, string $b;
> >> var int $a, protected $b;
> >> private $a, float $b;
> >>
> >> That seems fairly easy for a reader to follow, reasonably consistent,
> and
> >> I presume straightforward to implement (not being a C developer I
> hand-wave
> >> that part...).  If you want to do something more complex... make it
> >> multiple statements.  That's why multiple statements exist.
> >>
> >> Zeev, is that an accurate summary of what you're arguing?
> >>
>
> Exactly (human version :)
>
> Zeev
>



--=20
Guilherme Blanco
MSN: guilhermeblanco@hotmail.com
GTalk: guilhermeblanco
Toronto - ON/Canada

--001a113cd5b875b8c7052f5c5f64--