Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92031
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 65.55.169.144 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>
References: <CAF+90c95i=u8rE_vA9WOuZ7VjSkWLxFPRoRykWAm2337mV=JeA@mail.gmail.com>
 <CY1PR0201MB1786E14B3CBEE673D5EF795BBF980@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CAF+90c83ezPZZN4YU1jcEFAp3popRVtAUk86fCQDgmwOqojwmQ@mail.gmail.com>
 <CAEbg-4ZhrThoeUoMYmKiyvNNQBXAV8u4293+Dvaub7ZycudS9A@mail.gmail.com>
 <CY1PR0201MB1786E629E54910939F6D4151BF980@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CAF+90c9ZzT6aODUSpNys+xtaR7HFZGqzDhJ06WtAgipuJKpchw@mail.gmail.com>
CC: Alexander Lisachenko <lisachenko.it@gmail.com>, Antony Dovgal
	<antony.dovgal@gmail.com>, PHP internals <internals@lists.php.net>
Message-ID: <56FC33E4.8000007@zend.com>
Date: Wed, 30 Mar 2016 23:15:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <CAF+90c9ZzT6aODUSpNys+xtaR7HFZGqzDhJ06WtAgipuJKpchw@mail.gmail.com>
Content-Type: multipart/alternative;
	boundary="------------000800090702060702070601"
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2016 20:15:45.3017 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1791
Subject: Re: [PHP-DEV] Forbid binding methods to incompatible $this
From: dmitry@zend.com (Dmitry Stogov)

--------------000800090702060702070601
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit



On 03/30/2016 10:46 PM, Nikita Popov wrote:
> On Wed, Mar 30, 2016 at 6:18 PM, Dmitry Stogov <dmitry@zend.com 
> <mailto:dmitry@zend.com>> wrote:
>
>     Great it's not used anymore &#X1f60a
>
>     I personally agree to remove this.
>
>
>     Nikita, can you also investigate the need for double pointer to
>     object in
>
>
>     typedef union _zend_function
>     *(*zend_object_get_method_t)(zend_object **object, zend_string
>     *method, const zval *key);
>
>
>     As I remember, it's necessary only for some SPL hack, and looks
>     like a terrible design decision.
>
> This is used for forwarding method calls to the the "inner" object in 
> SPL iterators. It's basically the internal equivalent of doing:
>
> function __call($method, $args) {
>     return $this->inner->$method(...$args);
> }
>
> I don't think we can drop this feature at this point (deprecate?). We 
> can of course change the implementation to use a trampoline function 
> to avoid the zend_object** hack, but I'm not sure that would be 
> worthwhile.

thank you for discovering this.
Of course we can't drop or change SPL behavior.
Trampoline looks like a possible but too complex solution.
anyway, it would be great to remove this hack.

Thanks. Dmitry.


>
> Nikita


--------------000800090702060702070601
Content-Type: multipart/related;
	boundary="------------040803030202020502010202"

--------------040803030202020502010202
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <br>
    <br>
    <div class="moz-cite-prefix">On 03/30/2016 10:46 PM, Nikita Popov
      wrote:<br>
    </div>
    <blockquote
cite="mid:CAF+90c9ZzT6aODUSpNys+xtaR7HFZGqzDhJ06WtAgipuJKpchw@mail.gmail.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">On Wed, Mar 30, 2016 at 6:18 PM,
            Dmitry Stogov <span dir="ltr">&lt;<a moz-do-not-send="true"
                href="mailto:dmitry@zend.com" target="_blank">dmitry@zend.com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div dir="ltr">
                <div
style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif">
                  <p>Great it's not used anymore <img
                      style="vertical-align:bottom" alt="&amp;#X1f60a"
                      src="cid:part2.04070700.08070008@zend.com"></p>
                  <p>I personally agree to remove this.</p>
                  <p><br>
                  </p>
                  <p>Nikita, can you also investigate the need for
                    double pointer to object in<br>
                  </p>
                  <p><br>
                  </p>
                  <p>typedef union _zend_function
                    *(*zend_object_get_method_t)(zend_object **object,
                    zend_string *method, const zval *key);<br>
                  </p>
                  <p><br>
                  </p>
                  <p>As I remember, it's necessary only for some SPL
                    hack, and looks like a terrible design decision.<br>
                  </p>
                </div>
              </div>
            </blockquote>
          </div>
          This is used for forwarding method calls to the the "inner"
          object in SPL iterators. It's basically the internal
          equivalent of doing:<br>
        </div>
        <div class="gmail_extra"><br>
          function __call($method, $args) {<br>
        </div>
        <div class="gmail_extra">    return
          $this-&gt;inner-&gt;$method(...$args);<br>
          }<br>
          <br>
        </div>
        <div class="gmail_extra">I don't think we can drop this feature
          at this point (deprecate?). We can of course change the
          implementation to use a trampoline function to avoid the
          zend_object** hack, but I'm not sure that would be worthwhile.<br>
        </div>
      </div>
    </blockquote>
    <br>
    thank you for discovering this.<br>
    Of course we can't drop or change SPL behavior.<br>
    Trampoline looks like a possible but too complex solution.<br>
    anyway, it would be great to remove this hack.<br>
    <br>
    Thanks. Dmitry.<br>
    <br>
    <br>
    <blockquote
cite="mid:CAF+90c9ZzT6aODUSpNys+xtaR7HFZGqzDhJ06WtAgipuJKpchw@mail.gmail.com"
      type="cite">
      <div dir="ltr">
        <div class="gmail_extra"><br>
        </div>
        <div class="gmail_extra">Nikita<br>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>

--------------040803030202020502010202
Content-Type: image/png
Content-Transfer-Encoding: base64
Content-ID: <part2.04070700.08070008@zend.com>

iVBORw0KGgoAAAANSUhEUgAAABMAAAATCAYAAAByUDbMAAAAGXRFWHRTb2Z0d2FyZQBBZG9i
ZSBJbWFnZVJlYWR5ccllPAAAAYpJREFUeNpi/P//PwO1ACM2wf9njBWAVD4QBwCxApLUAyDe
AMQTGU3OPkDRA3QUIxaD+oFUAREOaQQa2IDTMKBB84FUAgk+WwA0MBFmGBOaixJIDKYEoD64
65igBjkge+3CrW94TUCTr4eGMdxl8TCZxMYHDIZR1xk2HPiA1SCQOEgepA4J5CMbFgAPhM1v
wfTFW9+xGgYTh6lD1s8IdKIAkH4PEz1w9jOYVpBiZ1CQZMMw7MHzXwwPnv0Esx2MeRESxmcY
WYCUAbJiFAVYAMgCbJbAvPmAWjmACZqS4aHdOOs5wdgEBcWE5a8Y0HIGPAIOwETtjXkYJqIq
xAAgeQM1ThTzkQ2biB5mC7a8xZ7kgeICvMzoYTsRJaMDY3U9chIBpaMHz34xxPsKgwMcFIsL
gckB5KL+YllkgyYAg6oQJW9Ck8h+5NgFhd3GAx/humAGI2cGIHYEGvYBW0YHGTgf2YX4MjkQ
F4IMwlkEIeXVfByGwsqzAwTLMywGg7wNcvED9AIR3TCAAAMAqh+p+YMVeBQAAAAASUVORK5C
YII=
--------------040803030202020502010202--

--------------000800090702060702070601--