Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92022
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c83ezPZZN4YU1jcEFAp3popRVtAUk86fCQDgmwOqojwmQ@mail.gmail.com>
References: <CAF+90c95i=u8rE_vA9WOuZ7VjSkWLxFPRoRykWAm2337mV=JeA@mail.gmail.com>
	<CY1PR0201MB1786E14B3CBEE673D5EF795BBF980@CY1PR0201MB1786.namprd02.prod.outlook.com>
	<CAF+90c83ezPZZN4YU1jcEFAp3popRVtAUk86fCQDgmwOqojwmQ@mail.gmail.com>
Date: Wed, 30 Mar 2016 15:07:49 +0300
Message-ID: <CAEbg-4ZhrThoeUoMYmKiyvNNQBXAV8u4293+Dvaub7ZycudS9A@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Dmitry Stogov <dmitry@zend.com>, Antony Dovgal <antony.dovgal@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1140219e9ed4f8052f42fe15
Subject: Re: [PHP-DEV] Forbid binding methods to incompatible $this
From: lisachenko.it@gmail.com (Alexander Lisachenko)

--001a1140219e9ed4f8052f42fe15
Content-Type: text/plain; charset=UTF-8

Hello, internals!

Go! AOP was used closure rebinding to an incompatible context only for one
minor specific feature, called privileged advices, where method was
executing in the context of target class. But all main closure binding in
the framework core work only with compatible contexts, so everything is ok
with PHP7 now.

So, this new patch is ok for me. Anyway, if I need this functionality
again, I can convert methods to the closures via AST transformation of
classes.

2016-03-30 14:02 GMT+03:00 Nikita Popov <nikita.ppv@gmail.com>:

> On Wed, Mar 30, 2016 at 11:34 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
> > I agree, this ability is a dirty and annoying hack, but I'm sure, some
> > people use it.
> >
> > Tony, you don't use this in the new runkit replacement? :)
> >
> > Thanks. Dmitry.
> >
>
> Is this referring to https://github.com/badoo/soft-mocks? If so, searching
> the codebase for getClosure gives no results, so it shouldn't be affected.
>
> I know that the Go! AOP framework used to do some odd things with closure
> binding on methods. However their use case was *already* completely broken
> by the limitations we added in 7.0 and the feature was removed.
>
> Nikita
>

--001a1140219e9ed4f8052f42fe15--