Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:92009
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 65.55.169.133 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>, Pierre Joye <pierre.php@gmail.com>
References: <CABDNdAHwgx+LJRc_gi9citiypxxWVGFMB+6hrmU+vVYDWCDV_g@mail.gmail.com>
 <56F14572.701@gmail.com> <56F15EF5.80006@telia.com>
 <56F16023.1010002@gmail.com>
 <CAPhkiZxYwXKLp8ASkjiwXgzDtjKxJ8rYROCM-t=8sU5=efhg2w@mail.gmail.com>
 <CAPhkiZwOJOkNu4N=h+wQRX4w8-KV=zg9x4khhLRLu199YcqZxw@mail.gmail.com>
 <CABDNdAGh4OjkkEQim6oYK=sZ=zj1Q==HzE=SLJ1E8=a=ku1DqA@mail.gmail.com>
 <CY1PR0201MB17863E4B9D9F53151A900DCDBF870@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CAL=_i_mNwmpg0PWmrm3nTZxn6s33u2QUzavk8w0Fk1OGvbWJtA@mail.gmail.com>
 <CY1PR0201MB1786AAFDC6170AB1585CA7F5BF870@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CY1PR0201MB17867DAC10D401EE9EC49CBCBF870@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CAL=_i_knwzrcXdx1k4ii8YKzrgaREBFcHYGC9ZV_J05ZWVWmzg@mail.gmail.com>
 <CAEZPtU5j8X35w-Vc6L=j_Lrbm1i-ukX_2k0awxgTR8D-us796A@mail.gmail.com>
 <CAL=_i_mfUy0nv3FWtYVgzpMVUNyA8zBpxuu13cZ-j0Nr1BOkPA@mail.gmail.com>
 <CAL=_i_=7A8iC81KXuDMCHA_q-3=nB97nE1KePDZF5eVcEbdzmA@mail.gmail.com>
CC: PHP internals <internals@lists.php.net>, Philip Sturgeon
	<pjsturgeon@gmail.com>, "krakjoe@php.net" <krakjoe@php.net>
Message-ID: <56FB7096.9090602@zend.com>
Date: Wed, 30 Mar 2016 09:22:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <CAL=_i_=7A8iC81KXuDMCHA_q-3=nB97nE1KePDZF5eVcEbdzmA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2016 06:22:29.3908 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1787
Subject: Re: [PHP-DEV] [RFC Discussion] Typed Properties
From: dmitry@zend.com (Dmitry Stogov)



On 03/30/2016 08:13 AM, Joe Watkins wrote:
> Morning Dmitry,
>
>      So, I quickly reviewed the RFC and patch.
>
>      Static properties, and mixed declarations, are now explained in the RFC.
Thanks. I'm not agree with decisions, but RFC is more complete now.
It would be great to have "static" typed properties at the same time, 
but this may be more difficult.
Mixed declarations decision looks wrong to me, but right to some others. 
From implementation point of view, it's not a big problem to change it.

>
>      I made a couple of changes to the fetch_obj_w stuff, I'd be grateful if
> you could review that ... I didn't think I had got all possible
> combinations, should be bit better, and drier ...
>
>      The overflow related stuff, I'll fix and explain in the RFC, but I'll
> let you have a go at perf stuff, and other outstanding things now ...
>
>      */me leaves patch alone*

OK. I'll try to do something today.

Thanks. Dmitry.

>
> Cheers
> Joe
>
> On Wed, Mar 30, 2016 at 5:26 AM, Joe Watkins <pthreads@pthreads.org> wrote:
>
>> Morning Pieere, Dmitry, all ...
>>
>> Actually it's not so simple ... for object properties we have ASSIGN_OBJ
>> opcode, but we don't have a special opcode for static properties, and
>> ASSIGN doesn't have any information about where the var came from, and nor
>> should it have that information ...
>>
>> I'm going to stick the original decision, static properties don't belong
>> until typed variables are a thing ...
>>
>> Cheers
>> Joe
>>
>> On Wed, Mar 30, 2016 at 4:57 AM, Pierre Joye <pierre.php@gmail.com> wrote:
>>
>>> On Mar 30, 2016 10:17 AM, "Joe Watkins" <pthreads@pthreads.org> wrote:
>>>> Morning Dmitry,
>>>>
>>>>> 1) static typed properties are prohibited. why?
>>>> Feels like that's a separate feature, static properties are as good as
>>>> makes no difference, global variables.
>>>>
>>>> Instance properties, the engine has good control over their
>>> manipulation,
>>>> for static properties it doesn't, it's not impossible, but feels
>>> separate.
>>>
>>> Internally different but from users perspective it is the same (a class
>>> property). It would be nice to support that at the same time to avoid
>>> confusion.
>>>
>>