Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91993
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 65.55.169.110 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>
CC: Phil Sturgeon <pjsturgeon@gmail.com>, "krakjoe@php.net" <krakjoe@php.net>,
	"internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC Discussion] Typed Properties
Thread-Index: AQHRf6IoPDUZe6dKO0uOqXcCfmmOFZ9cVmwAgAAC8ICAAAQ6gIAAArwAgAAHWICAAdLfgIAF1WiAgAAYowCAAVH4AIAAHmmAgAABaICAAEfhgIAAIEOAgAqejYCAAAhCX4AABJQAgAABThw=
Date: Tue, 29 Mar 2016 16:24:04 +0000
Message-ID: <CY1PR0201MB1786AAFDC6170AB1585CA7F5BF870@CY1PR0201MB1786.namprd02.prod.outlook.com>
References: <CABDNdAHwgx+LJRc_gi9citiypxxWVGFMB+6hrmU+vVYDWCDV_g@mail.gmail.com>
	<1458149992.3969.2.camel@kuechenschabe>
	<BLU436-SMTP1394648F9BABA2FA74BFC4DE28A0@phx.gbl>
	<1458151531.3969.8.camel@kuechenschabe>
	<BLU436-SMTP2092DD6AFBC93D83397A3C7E28A0@phx.gbl>
	<1458153695.3969.16.camel@kuechenschabe>	<3F.70.02405.6803BE65@pb1.pair.com>
	<56F01545.8080008@gmail.com>
	<CAF+90c-Z82kBT18ivvKejD5_dBf=dtbNYN-cZcyO1K=0C1WcLA@mail.gmail.com>
	<56F14572.701@gmail.com>	<56F15EF5.80006@telia.com>
	<56F16023.1010002@gmail.com>
	<CAPhkiZxYwXKLp8ASkjiwXgzDtjKxJ8rYROCM-t=8sU5=efhg2w@mail.gmail.com>
	<CAPhkiZwOJOkNu4N=h+wQRX4w8-KV=zg9x4khhLRLu199YcqZxw@mail.gmail.com>
	<CABDNdAGh4OjkkEQim6oYK=sZ=zj1Q==HzE=SLJ1E8=a=ku1DqA@mail.gmail.com>
	<CY1PR0201MB17863E4B9D9F53151A900DCDBF870@CY1PR0201MB1786.namprd02.prod.outlook.com>,<CAL=_i_mNwmpg0PWmrm3nTZxn6s33u2QUzavk8w0Fk1OGvbWJtA@mail.gmail.com>
In-Reply-To: <CAL=_i_mNwmpg0PWmrm3nTZxn6s33u2QUzavk8w0Fk1OGvbWJtA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_CY1PR0201MB1786AAFDC6170AB1585CA7F5BF870CY1PR0201MB1786_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2016 16:24:04.3480
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1787
Subject: Re: [PHP-DEV] [RFC Discussion] Typed Properties
From: dmitry@zend.com (Dmitry Stogov)

--_000_CY1PR0201MB1786AAFDC6170AB1585CA7F5BF870CY1PR0201MB1786_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Thanks. I'll start tomorrow morning and will try to send you update by the =
evening,

________________________________
From: Joe Watkins <pthreads@pthreads.org>
Sent: Tuesday, March 29, 2016 19:18
To: Dmitry Stogov
Cc: Phil Sturgeon; krakjoe@php.net; internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC Discussion] Typed Properties

Hi Dmitry,

    The patch is pretty close to complete.

    When you start to dig a bit further, you'll notice that I prepared for =
using cached pointers to prop info, but, I'm not sure how to allocate those=
 as the handlers are using the currently allocated slots so differently.

    I also patched opcache, but it's probably wrong (or not good enough, no=
t sure what to do about type_ce).

    Please do start working on the patch, that would be great ... I'll leav=
e it alone for you to do your thing :)

Cheers
Joe

On Tue, Mar 29, 2016 at 5:12 PM, Dmitry Stogov <dmitry@zend.com<mailto:dmit=
ry@zend.com>> wrote:
Hi Phil, hi Joe,

Is your patch complete?

I took just a brief review yet, and I would like to make a deep check once =
again (and may be optimization).
I saw, the patch makes some slowdown, but less than I expected.
If you are not going to modify the patch in next two days, I would start wo=
rking on it tomorrow.

RFC itself looks fine.

Thanks. Dmitry.

________________________________________
From: Phil Sturgeon <pjsturgeon@gmail.com<mailto:pjsturgeon@gmail.com>>
Sent: Tuesday, March 29, 2016 18:32
To: Andrey Andreev
Cc: internals@lists.php.net<mailto:internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC Discussion] Typed Properties

I'd like to thank everyone for their feedback on this RFC!

It looks like the majority of concerns were solved during the course
of this discussion, which is great news.

The RFC has been expanded in a few areas to take care of a few other
concerns, so please go and review it and let me know if you have any
feedback.

https://wiki.php.net/rfc/typed-properties

Voting will start in a few days.

Cheers,
Phil

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php


--_000_CY1PR0201MB1786AAFDC6170AB1585CA7F5BF870CY1PR0201MB1786_--